-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Corrects $SPARK_HOME errors in spark container #1009
base: master
Are you sure you want to change the base?
Fix: Corrects $SPARK_HOME errors in spark container #1009
Conversation
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Make sure to check out the developer guide for guidance on testing your change. |
…scoffee/mmlspark into update-spark-container
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
+ Coverage 84.13% 84.49% +0.35%
==========================================
Files 201 199 -2
Lines 9306 9172 -134
Branches 554 543 -11
==========================================
- Hits 7830 7750 -80
+ Misses 1476 1422 -54
Continue to review full report at Codecov.
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@brockneedscoffee - looks good but we dont test docker notebook as part of the build yet so could you manually test these out? Also could you group all the run steps together into a single run step and put ENV stuff in top of docker. Putting all of the run steps together (and deleting ant .tgzs you download in these steps) makes the docker image considerably smaller thanks! |
ENV PATH /opt/conda/bin:$PATH | ||
ENV JAVA_HOME /usr/lib/jvm/java-1.8.0-openjdk-amd64 | ||
|
||
# Build-essentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group run steps together for smaller docker image
When installing spark via miniconda the spark home is not set so you cannot run spark in AML. You will get errors when you try to set the spark context or if you set the framework to pyspark in an AML pipeline step. This PR installs spark, sets the home, and installs open mpi dependency.