Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add some code coverage #1392

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

niehaus59
Copy link
Contributor

Adding some tests to contribute to code coverage.
Submitting for PR to see if the tests run ok in the pipeline.

@niehaus59 niehaus59 changed the title Add some code coverage test: Add some code coverage Feb 10, 2022
imatiach-msft
imatiach-msft previously approved these changes Feb 10, 2022
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests!

@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Feb 10, 2022
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

@niehaus59 niehaus59 dismissed stale reviews from mhamilton723 and imatiach-msft via 1acac3e February 10, 2022 23:36
@niehaus59
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1392 (1acac3e) into master (52b440c) will decrease coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   84.77%   83.97%   -0.80%     
==========================================
  Files         287      287              
  Lines       14250    14250              
  Branches      719      719              
==========================================
- Hits        12080    11967     -113     
- Misses       2170     2283     +113     
Impacted Files Coverage Δ
.../azure/synapse/ml/lightgbm/LightGBMRegressor.scala 17.24% <0.00%> (-56.90%) ⬇️
...oft/azure/synapse/ml/lightgbm/LightGBMRanker.scala 15.49% <0.00%> (-45.08%) ⬇️
...ure/synapse/ml/lightgbm/dataset/DatasetUtils.scala 25.00% <0.00%> (-36.12%) ⬇️
.../synapse/ml/lightgbm/dataset/LightGBMDataset.scala 47.56% <0.00%> (-15.86%) ⬇️
...azure/synapse/ml/lightgbm/params/TrainParams.scala 84.37% <0.00%> (-15.63%) ⬇️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 58.33% <0.00%> (-15.01%) ⬇️
...ure/synapse/ml/lightgbm/LightGBMModelMethods.scala 55.55% <0.00%> (-11.12%) ⬇️
...rosoft/azure/synapse/ml/logging/BasicLogging.scala 93.33% <0.00%> (-6.67%) ⬇️
...osoft/azure/synapse/ml/core/contracts/Params.scala 93.47% <0.00%> (-2.18%) ⬇️
...osoft/azure/synapse/ml/lightgbm/LightGBMBase.scala 93.82% <0.00%> (-1.13%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b440c...1acac3e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants