Upgrade dependencies to support intellij 2025.1 eap #9978
+34
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR upgrades the IntelliJ dependencies to support version 2025.1 EAP while temporarily disabling a part of the SSH browsing functionality.
- Upgraded Kotlin from "1.9.24" to "2.1.0"
- Upgraded intellijPlatform from "2.1.0" to "2.2.2-SNAPSHOT"
- Commented out the SshTargetType browsing call in the Azure VM target type to address SSH breakage issues
Reviewed Changes
| File | Description |
|---|---|
| PluginsAndFeatures/azure-toolkit-for-intellij/gradle/libs.versions.toml | Upgraded dependency versions to support IntelliJ 2025.1 EAP |
| PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-vm/src/main/java/com/microsoft/azure/toolkit/intellij/vm/runtarget/AzureVmTargetType.java | Temporarily commented out the SSH browsing functionality |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| @@ -117,7 +117,7 @@ public final void actionPerformed(ActionEvent it) { | |||
| if (configuration instanceof SshTargetEnvironmentConfiguration) { | |||
| final SshConfig sshConfig = ((SshTargetEnvironmentConfiguration) configuration).findSshConfig(project); | |||
| final SshUiData uiData = sshConfig != null ? new SshUiData(sshConfig, true) : null; | |||
| SshTargetType.Companion.handleBrowsing$intellij_remoteRun(uiData, project, title, component, textComponentAccessor); | |||
| // SshTargetType.Companion.handleBrowsing$intellij_remoteRun(uiData, project, title, component, textComponentAccessor); | |||
There was a problem hiding this comment.
Commenting out the SshTargetType call disables SSH functionality; consider adding a note referencing the related ticket or temporary workaround to clarify that this is an intentional short-term change.
Suggested change
| // SshTargetType.Companion.handleBrowsing$intellij_remoteRun(uiData, project, title, component, textComponentAccessor); | |
| // SshTargetType.Companion.handleBrowsing$intellij_remoteRun(uiData, project, title, component, textComponentAccessor); | |
| // Note: The above line is commented out to temporarily disable SSH functionality. | |
| // Refer to ticket XYZ-123 for more details and the temporary workaround. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Upgrade dependencies to support intellij 2025.1 eap
TODO: Investigate how to revert the break SSH feature
Does this close any currently open issues?
Any relevant logs, screenshots, error output, etc.?
Any other comments?
…
Has this been tested?