[SQL] Adding logs to SqlRetryService (#4233)

* Better logs in SqlRetryServicer

* Fix error in tests.

src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlRetry/SqlRetryService.cs

@@ -233,6 +233,8 @@ public async Task ExecuteSql<TLogger>(Func<SqlConnection, CancellationToken, Sql
                     {
                         sqlException = sqlEx;
                     }
+
+                    logger.LogInformation(ex, $"Attempt {retry}: {ex.Message}");
                 }
 
                 await Task.Delay(_retryMillisecondsDelay, cancellationToken);
@@ -474,6 +476,9 @@ public async Task<SqlConnection> GetConnection<TLogger>(ISqlConnectionBuilder sq
                 // Connection is never opened by the _sqlConnectionBuilder but RetryLogicProvider is set to the old, deprecated retry implementation. According to the .NET spec, RetryLogicProvider
                 // must be set before opening connection to take effect. Therefore we must reset it to null here before opening the connection.
                 conn.RetryLogicProvider = null; // To remove this line _sqlConnectionBuilder in healthcare-shared-components must be modified.
+                logger.LogInformation($"Retrieved {isReadOnlyConnection}connection to the database in {sw.Elapsed.TotalSeconds} seconds.");
+
+                sw = Stopwatch.StartNew();
                 await conn.OpenAsync(cancel);
                 logger.LogInformation($"Opened {isReadOnlyConnection}connection to the database in {sw.Elapsed.TotalSeconds} seconds.");
 

test/Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/SqlRetryServiceTests.cs

@@ -493,7 +493,8 @@ await sqlRetryService.ExecuteSql(
                         CancellationToken.None);
                 }
 
-                Assert.Contains("Opened", logger.LogRecords[0].Message); // Check that logging of connection open was logged.
+                Assert.StartsWith("Retrieved", logger.LogRecords[0].Message); // Check that logging of connection open was logged.
+                Assert.StartsWith("Opened", logger.LogRecords[1].Message); // Check that logging of connection open was logged.
                 logger.LogRecords.RemoveAll(_ => _.Exception == null);
                 Assert.Single(logger.LogRecords);