fix(declarative-chart): Heatmap black color fix #33751
Open
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 31, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Keytip.Offset.chromium.png | 121 | Changed |
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
srmukher
reviewed
Jan 31, 2025
| @@ -627,11 +627,13 @@ export const transformPlotlyJsonToHeatmapProps = (input: PlotlySchema): IHeatMap | |||
| x: input.layout?.xaxis?.type === 'date' ? (xVal as Date) : xVal ?? 0, | |||
| y: input.layout?.yaxis?.type === 'date' ? (yVal as Date) : yVal, | |||
| value: zVal, | |||
| rectText: zVal, | |||
| rectText: isNaN(zVal) ? 'No Data' : zVal, | |||
There was a problem hiding this comment.
Can you add tests for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Related Issue(s)