U/sgriffin/sid

[stephenegriffin]

This pull request includes several changes to improve the handling and testing of security descriptors and access control entries (ACEs). The most important changes include the modification of the SDToString function, the addition of new test data files, and the restructuring of the project to better organize the smart view components.

Improvements to security descriptor handling:

• UI/MySecInfo.cpp: Replaced SDToString with NTSDToString and simplified the DebugPrint output.

Addition of new test data files:

• Added new test data files for ACE and security descriptor tests (UnitTest/SmartViewTestData/In/ACECONTAINER-1.dat, UnitTest/SmartViewTestData/In/ACEFB-1.dat, UnitTest/SmartViewTestData/In/ACEMESSAGE-1.dat, UnitTest/SmartViewTestData/In/ACEMESSAGE-2.dat, UnitTest/SmartViewTestData/In/ACL-1.dat, UnitTest/SmartViewTestData/In/NTSD-1.dat, UnitTest/SmartViewTestData/In/NTSD-5.dat, UnitTest/SmartViewTestData/In/SECURITYDESCRIPTOR-1.dat, UnitTest/SmartViewTestData/In/SID-6.dat, UnitTest/SmartViewTestData/In/SID-7.dat). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Project restructuring:

• core/core.vcxproj: Moved security descriptor related headers and source files to a new directory smartview/SD and updated project files accordingly. [1] [2] [3] [4]
• core/core.vcxproj.filters: Updated filters to reflect the new directory structure for SD components. [1] [2] [3] [4]

Codebase simplification:

• UnitTest/tests/sidtest.cpp: Removed redundant ACEToString and SDToString test methods and updated Test_LookupAccountSid method. [1] [2] [3]
• core/interpret/sid.cpp: Included new headers for NTSD and SmartView components.

These changes enhance the maintainability and clarity of the codebase, improve the organization of smart view components, and expand the test coverage for security descriptors and ACEs.

[github-actions]

Test Results

    8 files  ± 0      8 suites  ±0   46s ⏱️ +8s
  251 tests + 7    251 ✅ + 7  0 💤 ±0  0 ❌ ±0 
2 008 runs  +56  2 008 ✅ +56  0 💤 ±0  0 ❌ ±0 

Results for commit a314648. ± Comparison against base commit 270e12c.

This pull request removes 6 and adds 13 tests. Note that renamed tests count towards both.

SmartViewTest.SmartViewTest ‑ SECURITYDESCRIPTOR_2
SmartViewTest.SmartViewTest ‑ SECURITYDESCRIPTOR_3
SmartViewTest.SmartViewTest ‑ SECURITYDESCRIPTOR_4
sidtest.sidtest ‑ Test_ACEToString
sidtest.sidtest ‑ Test_GetTextualSid
sidtest.sidtest ‑ Test_SDToString

SmartViewTest.SmartViewTest ‑ ACECONTAINER_1
SmartViewTest.SmartViewTest ‑ ACEFB_1
SmartViewTest.SmartViewTest ‑ ACEMESSAGE_1
SmartViewTest.SmartViewTest ‑ ACEMESSAGE_2
SmartViewTest.SmartViewTest ‑ ACL_1
SmartViewTest.SmartViewTest ‑ NTSD_1
SmartViewTest.SmartViewTest ‑ NTSD_2
SmartViewTest.SmartViewTest ‑ NTSD_3
SmartViewTest.SmartViewTest ‑ NTSD_4
SmartViewTest.SmartViewTest ‑ NTSD_5
…

♻️ This comment has been updated with latest results.