-
Notifications
You must be signed in to change notification settings - Fork 105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, left some comments, rest looks good to me!
samples/todo-app/README.md
Outdated
|
||
This is a simple deployment that exposes the frontend using a service of type `LoadBalancer`. Wait for all the pods to be running and for the external IP of the `frontend` service to become available. | ||
|
||
If you are testing with MiniKube, you will need to use `minikube tunnel` in to resolve an external IP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "in" please.
samples/todo-app/README.md
Outdated
|
||
## Debug the stats-api service | ||
|
||
We will now use the Bridge to Kubernetes extension to demonstarte how traffic from the Kubernetes cluster can be redirected to a locally running version of the stats-api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling
samples/todo-app/README.md
Outdated
Choose `Run Script: dev` as the launch task. | ||
![](/images/launch_task.png) | ||
|
||
> Note: You will be prompted to allow the EndpointManager to run elevated and modify your hosts file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this after the isolated/non-isolated option
samples/todo-app/README.md
Outdated
You have the option of running isolated or not isolated. If you run isolated, only your requests are routed to your local process; other developers can use the cluster without being affected. If you don't run isolated, all traffic is redirected to your local process. For more information on this option, see [Using routing capabilities for developing in isolation](https://docs.microsoft.com/en-us/visualstudio/containers/overview-bridge-to-kubernetes?view=vs-2019#using-routing-capabilities-for-developing-in-isolation). For this example, we will proceed with non-isolated. | ||
![](/images/isolation.png) | ||
|
||
The Bridge to Kubernetes debugging profile has been sussccessfully configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling
|
||
> Note: You will be prompted to allow the EndpointManager to run elevated and modify your hosts file. | ||
|
||
You have the option of running isolated or not isolated. If you run isolated, only your requests are routed to your local process; other developers can use the cluster without being affected. If you don't run isolated, all traffic is redirected to your local process. For more information on this option, see [Using routing capabilities for developing in isolation](https://docs.microsoft.com/en-us/visualstudio/containers/overview-bridge-to-kubernetes?view=vs-2019#using-routing-capabilities-for-developing-in-isolation). For this example, we will proceed with non-isolated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to have this doc show the isolated mode. That way we can talk about the nip.io URL and it doesn't come as a surprise to users who see it for the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or if we want, we can talk to both scenarios if that makes sense.
samples/todo-app/README.md
Outdated
kubectl get services -n todo-app | ||
|
||
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE | ||
frontend LoadBalancer 10.0.49.177 52.149.235.179 80:30145/TCP 18h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using the minikube example, shouldn't this be 127.0.0.1?
samples/todo-app/README.md
Outdated
|
||
Press play and let the request contine complete transparently. | ||
|
||
This is just one example on how to use Bridge to Kubernetes on non-AKS clusters. Try it on your own projet next! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling
No description provided.