Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude closing single or double quote from URL in URL recogniser #1532

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spacedragonx
Copy link

Exclude closing single or double quote from URL

Describe your changes
This PR updates the URL regex pattern to correctly exclude trailing single (') and double (") quotes from captured URLs. The updated pattern ensures that quotes are treated as stopping characters, preventing them from being included in the matched URL.

Issue reference

This PR fixes issue #1531

Checklist

  • [ yes] I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • [yes ] My PR contains documentation updates / additions if required

@spacedragonx
Copy link
Author

@microsoft-github-policy-service agree

@spacedragonx
Copy link
Author

@spacedragonx please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant