Add Oklab based color scheme "Ottosson" #18502
Merged
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
|
Campbell
Ottosson
|
DHowett
approved these changes
Feb 3, 2025
nguyen-dows
approved these changes
Feb 3, 2025
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
Campbell has been the default color scheme for a long time now, but it has quite some issues with hue and chroma. This PR introduces a new scheme which was created using the Oklab color space to find colors with maximal distance to each other and well distributed and consistent hue and chroma. Because of this, I've named the scheme after the creator of Oklab. Closes #17818 (cherry picked from commit e60acbc) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgW-IC0 Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
Campbell has been the default color scheme for a long time now, but it has quite some issues with hue and chroma. This PR introduces a new scheme which was created using the Oklab color space to find colors with maximal distance to each other and well distributed and consistent hue and chroma. Because of this, I've named the scheme after the creator of Oklab. Closes #17818 (cherry picked from commit e60acbc) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgW-IDA Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
Campbell has been the default color scheme for a long time now, but it has quite some issues with hue and chroma. This PR introduces a new scheme which was created using the Oklab color space to find colors with maximal distance to each other and well distributed and consistent hue and chroma. Because of this, I've named the scheme after the creator of Oklab. Closes #17818 (cherry picked from commit e60acbc) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgW-IC8 Service-Version: 1.21
|
Reminds me a lot of root loops, which already has WT support. Björn Ottosson's work on OkLab deserves significant recognition. He has made color theory accessible to the mere mortal that previous methods would just savagely footgun without remorse. |
DHowett
pushed a commit
that referenced
this pull request
Feb 20, 2025
Okay, here is a challenge for the default color scheme. This PR adds the [Dimidium] color scheme. Refs #17818 Refs #18502 I adjusted colors using CAM16. I prioritized lightness so that all colors (especially blue) has appropriate contrast with the background. [Brief information about the Dimidium color scheme](https://github.com/dofuuz/dimidium/blob/main/README.md) [Detailed explanation on crafting the color scheme with CAM16](https://dofuuz.github.io/color/2024/03/17/dimidium-terminal-color-scheme.html) [Dimidium]: https://github.com/dofuuz/dimidium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Campbell has been the default color scheme for a long time now,
but it has quite some issues with hue and chroma.
This PR introduces a new scheme which was created using the Oklab
color space to find colors with maximal distance to each other
and well distributed and consistent hue and chroma.
Because of this, I've named the scheme after the creator of Oklab.
Closes #17818