-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements for the CodeGeneration in VSCode extension #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
January 15, 2025 08:47
All changed packages have been documented.
|
chunyu3
force-pushed
the
VSCodeExtension
branch
2 times, most recently
from
January 15, 2025 08:56
f94a686
to
57c2798
Compare
You can try these changes here
|
RodgeFu
reviewed
Jan 16, 2025
chunyu3
force-pushed
the
VSCodeExtension
branch
from
January 16, 2025 04:51
efb5d63
to
ce43423
Compare
RodgeFu
reviewed
Jan 18, 2025
RodgeFu
reviewed
Jan 18, 2025
allenjzhang
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should update this to target the release/xyz
branch if you want to release this as an hotfix
chunyu3
added a commit
to chunyu3/typespec
that referenced
this pull request
Jan 24, 2025
…ft#5620) Fix microsoft#5613 enhance the code generation in vscode extension: - The existing emitters will not be filter out from the emitter selection page - remove `settings` button - honor the default output dir from compiler by default: "emitter-output-dir: {output-dir}/{emitter-namer}" - when user selects a new emitters, generate code directly instead of go back to the top list to ask user select again
chunyu3
added a commit
to chunyu3/typespec
that referenced
this pull request
Jan 24, 2025
…ft#5620) Fix microsoft#5613 enhance the code generation in vscode extension: - The existing emitters will not be filter out from the emitter selection page - remove `settings` button - honor the default output dir from compiler by default: "emitter-output-dir: {output-dir}/{emitter-namer}" - when user selects a new emitters, generate code directly instead of go back to the top list to ask user select again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5613
enhance the code generation in vscode extension:
settings
button