Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements for the CodeGeneration in VSCode extension #5620

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

chunyu3
Copy link
Contributor

@chunyu3 chunyu3 commented Jan 15, 2025

Fix #5613
enhance the code generation in vscode extension:

  • The existing emitters will not be filter out from the emitter selection page
  • remove settings button
  • honor the default output dir from compiler by default: "emitter-output-dir: {output-dir}/{emitter-namer}"
  • when user selects a new emitters, generate code directly instead of go back to the top list to ask user select again

@chunyu3 chunyu3 added the ide Issues for VS, VSCode, Monaco, etc. label Jan 15, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 15, 2025

All changed packages have been documented.

  • typespec-vscode
Show changes

typespec-vscode - internal ✏️

some enhancement in UI

@chunyu3 chunyu3 force-pushed the VSCodeExtension branch 2 times, most recently from f94a686 to 57c2798 Compare January 15, 2025 08:56
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 15, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@chunyu3 chunyu3 requested a review from RodgeFu January 16, 2025 04:52
@chunyu3 chunyu3 requested a review from RodgeFu January 20, 2025 08:22
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update this to target the release/xyz branch if you want to release this as an hotfix

@chunyu3 chunyu3 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into microsoft:main with commit d65dd3e Jan 23, 2025
24 checks passed
@chunyu3 chunyu3 deleted the VSCodeExtension branch January 23, 2025 06:26
chunyu3 added a commit to chunyu3/typespec that referenced this pull request Jan 24, 2025
…ft#5620)

Fix microsoft#5613
enhance the code generation in vscode extension:

- The existing emitters will not be filter out from the emitter
selection page
- remove `settings` button
- honor the default output dir from compiler by default:
"emitter-output-dir: {output-dir}/{emitter-namer}"
- when user selects a new emitters, generate code directly instead of go
back to the top list to ask user select again
chunyu3 added a commit to chunyu3/typespec that referenced this pull request Jan 24, 2025
…ft#5620)

Fix microsoft#5613
enhance the code generation in vscode extension:

- The existing emitters will not be filter out from the emitter
selection page
- remove `settings` button
- honor the default output dir from compiler by default:
"emitter-output-dir: {output-dir}/{emitter-namer}"
- when user selects a new emitters, generate code directly instead of go
back to the top list to ask user select again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Some improvements for the CodeGeneration
6 participants