[grpc] Update to 1.46.3 #25071
[grpc] Update to 1.46.3 #25071
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/upb/vcpkg.json
Valid values for the license field can be found in the documentation
…otobuf_generate. Also add license to vcpkg.json
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for abseil have changed but the version was not updated
version: 20211102.1#1
old SHA: a155a4bc47fd9a3704b260f51d963a02f2b82615
new SHA: 84c9cd0c9b454866343894662c7d09b72f78e413
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Use the version scheme "version" instead of "version-string" in port "abseil".
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/abseil/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for grpc have changed but the version was not updated
version: 1.46.3
old SHA: 7bfd4a77e06252446c0da5534ec5302dca6b8be5
new SHA: 8410a2c3a3898c29b286a6bfe4a7e3d638bf661f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
FrankXie05
added
the
category:port-update
…ted descriptor.upb.h files just to use them when compiling target triplet
|
I think the arm64_windows pipeline had a bit of a hiccup, otherwise the pull request should be ready. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…C's pkgconfig patch
FrankXie05
added
depends:upstream-changes
|
Hi, when could this port request be merged into master? |
|
@FAKERINHEART Waiting for upstream response in protocolbuffers/protobuf#13755 |
|
I will continue to review this PR tomorrow since it's too huge. |
I think that has some risk. |
|
@FAKERINHEART Regarding gRPC 1.47.x: I would recommend to add 1.46.3 first and then immediately create another pr to add 1.47.x because 1.46 is the last version to support C++11 and will receive critical patches until 2023-06-01. I therefore think that it would be beneficial to have version 1.46 here in vcpkg so that people can use it in a version override if needed. |
|
@Tradias It sounds great! |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for upb have changed but the version was not updated
version: 2022-04-04
old SHA: b5d5c869f37a3090c70ad85182185efacf97bbf7
new SHA: de1d8718e4ea42428b87f4275352c4f3bbb6ac11
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for grpc have changed but the version was not updated
version: 1.46.3
old SHA: 1c6ae19974f859d5032d9f75b47be347bf4aaab0
new SHA: e3c2bbbb21b4605189be3118a13bbd84375fbebb
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for upb have changed but the version was not updated
version: 2022-04-04
old SHA: b5d5c869f37a3090c70ad85182185efacf97bbf7
new SHA: de1d8718e4ea42428b87f4275352c4f3bbb6ac11
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
JackBoosY
removed
depends:upstream-changes
Waiting on vcpkg to update gRPC tp 1.46, see microsoft/vcpkg#25071
Waiting on vcpkg to update gRPC to v1.46, see microsoft/vcpkg#25071
|
All features are tested successfully in the following triplet:
|
Waiting on vcpkg to update gRPC to v1.46, see microsoft/vcpkg#25071
What does your PR fix?
Fixes [grpc] update to 1.46.0 #24557
Which triplets are supported/not supported? Have you updated the CI baseline?
yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes