-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble domains, executors, and supervisory services #1263
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks generally good, but
|
Of course, this is wip. I made the server identifiers pairs of server id and ensemble domain. I will do supervisors, executors, and yes tests, next. |
srfi/19 current-date and formatting are extremely slow; just utc it.
this will allow the ensemble tool to reach actor in the local ensemble through the supervisor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick comments after a first read-through. Second one is needed.
(def server-config-option | ||
(option 'config "-c" "--config" | ||
help: "location of the httpd configuration; when running as a standalone server it defaults to $GERBIL_PATH/httpd/config; when running as part of an ensemble this option is ignored")) | ||
|
||
(def ensemble-config-option | ||
(option 'config "-c" "--config" | ||
help: "location of the httpd ensemble configuration; it defaults to $GERBIL_PATH/ensemble/config")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the flags intentionally similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they are not used concurrently, and i want a contextual help.
(def config-path-option | ||
(option 'config "-c" "--config" | ||
help: "specify the configuration path")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another "-c" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i guess i could compress to just this.
|
||
``` | ||
1$ pushd site | ||
1$ gerbil httpd -G project/.gerbil config --root www --enable-servlets --handlers '(("/handler" . :demo/handler))' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-G" is used here but I can't find it in gxhttpd/opt.ss
or the base httpd
. Did I miss it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in tools/env.ss
In the folling we see how we can run an httpd ensemble with a standalone supervisor. | ||
|
||
First, let's configure the ensemble: | ||
- first we configure the httpd as usual -- notice the use of `-G env/local` so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-G env/local
-> lowercase 'g'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we use that for a flat that says do global .gerbil
http requests with a (local) httpd ensemble each, and another host | ||
acting as a load balancer using the example `rlb` program. | ||
|
||
See [src/tutorial/advanced-ensemble/rlb](https://github.com/mighty-gerbils/gerbil/tree/master/src/tutorial/advanced-ensemble/rlb) for the `rlb` code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404s, probably should point to https://github.com/mighty-gerbils/gerbil/blob/ensemble-domains/src/tutorial/advanced-ensemble/rlb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the pr hasn't merged yet!
It is where the file is going to be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved without reading everything. Live! Master! Now! :P
Let me fix the remaining broekn commands in gxensemble first. |
Implements ensemble domains, with supervisory services and the first implementation of the global execution environment.
Work Items