fix for byte array types, with 0 length (defaults to longblob)

http://code.google.com/p/migratordotnet/issues/detail?id=3
migratordotnet · Apr 21, 2008 · e82f7bc · e82f7bc
1 parent 65fea5c
commit e82f7bc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/core/Providers/TransformationProvider.cs b/app/core/Providers/TransformationProvider.cs
@@ -218,9 +218,9 @@ protected IColumnPropertiesMapper GetColumnMapper(Column column)
 
 			if (column.Type == typeof(byte[]))
 			{
-				if (column.Size <= Convert.ToInt32(byte.MaxValue))
+                if (column.Size <= Convert.ToInt32(byte.MaxValue) && column.Size > 0)
 					return TypeToSqlProvider.Binary(Convert.ToByte(column.Size));
-				else if (column.Size <= Convert.ToInt32(ushort.MaxValue))
+				else if (column.Size <= Convert.ToInt32(ushort.MaxValue) && column.Size > 0)
 					return TypeToSqlProvider.Blob;
 				else
 					return TypeToSqlProvider.LongBlob;

diff --git a/test/Providers/SqlServerTransformationProviderTest.cs b/test/Providers/SqlServerTransformationProviderTest.cs
@@ -37,5 +37,11 @@ public void SetUp()
 								new Column("TestId", typeof(int)));
 		}
 
+        [Test]
+        public void ByteColumnWillBeCreatedAsBlob()
+        {
+            _provider.AddColumn("Test2", "BlobColumn", typeof(byte[]));
+            Assert.IsTrue(_provider.ColumnExists("Test2", "BlobColumn"));
+        }
 	}
 }