Skip to content

Commit

Permalink
[SCSI] libfc: fix RNN_ID smashing skb payload
Browse files Browse the repository at this point in the history
The code that filled in the name server RNN_ID (register node name)
request had somehow gotten a line in it from the RFT_ID code
which copies 32 bytes of data over the relatively short payload.
This caused some corruption and hangs.

Simply deleted the extraneous line.

Signed-off-by: Joe Eykholt <[email protected]>
Signed-off-by: Robert Love <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Joe Eykholt authored and James Bottomley committed Dec 4, 2009
1 parent 59d9251 commit 6049d95
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion include/scsi/fc_encode.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ static inline int fc_ct_fill(struct fc_lport *lport,
ct = fc_ct_hdr_fill(fp, op, sizeof(struct fc_ns_rn_id));
hton24(ct->payload.rn.fr_fid.fp_fid,
fc_host_port_id(lport->host));
ct->payload.rft.fts = lport->fcts;
put_unaligned_be64(lport->wwnn, &ct->payload.rn.fr_wwn);
break;

Expand Down

0 comments on commit 6049d95

Please sign in to comment.