CORDA-1003: Fix duplicate detection on cache evict (corda#2499)

mikalv · Feb 12, 2018 · 805178d · 805178d
1 parent 10f3c0b
commit 805178d
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/node/src/test/kotlin/net/corda/node/services/persistence/DBTransactionStorageTests.kt b/node/src/test/kotlin/net/corda/node/services/persistence/DBTransactionStorageTests.kt
@@ -172,9 +172,22 @@ class DBTransactionStorageTests {
         assertEquals(expected, actual)
     }
 
-    private fun newTransactionStorage() {
+    @Test
+    fun `duplicates are detected when transaction is evicted from cache`() {
+        newTransactionStorage(cacheSizeBytesOverride = 0)
+        val transaction = newTransaction()
+        database.transaction {
+            val firstInserted = transactionStorage.addTransaction(transaction)
+            val secondInserted = transactionStorage.addTransaction(transaction)
+            require(firstInserted) { "We inserted a fresh transaction" }
+            require(!secondInserted) { "Second time should be redundant" }
+            println("$firstInserted $secondInserted")
+        }
+    }
+
+    private fun newTransactionStorage(cacheSizeBytesOverride: Long? = null) {
         database.transaction {
-            transactionStorage = DBTransactionStorage(NodeConfiguration.defaultTransactionCacheSize)
+            transactionStorage = DBTransactionStorage(cacheSizeBytesOverride ?: NodeConfiguration.defaultTransactionCacheSize)
         }
     }