Switch loops maintaining their own index variable to use enumerate().

cc/image.bzl

@@ -76,13 +76,11 @@ def cc_image(name, base=None, deps=[], layers=[], binary=None, **kwargs):
   elif deps:
     fail("kwarg does nothing when binary is specified", "deps")
 
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, binary=binary, layers=layers,

contrib/push-all.bzl

@@ -38,8 +38,7 @@ def _impl(ctx):
 
   scripts = []
   runfiles = []
-  index = 0
-  for tag in images:
+  for index, tag in enumerate(images.keys()):
     image = images[tag]
     # Leverage our efficient intermediate representation to push.
     legacy_base_arg = ""
@@ -77,7 +76,6 @@ def _impl(ctx):
 
     scripts += [out]
     runfiles += [out]
-    index += 1
 
   ctx.template_action(
     template = ctx.file._all_tpl,

d/image.bzl

@@ -49,13 +49,11 @@ def d_image(name, base=None, deps=[], layers=[], binary=None, **kwargs):
   elif deps:
     fail("kwarg does nothing when binary is specified", "deps")
 
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s_%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, binary=binary, layers=layers,

go/image.bzl

@@ -80,13 +80,11 @@ def go_image(name, base=None, deps=[], layers=[], binary=None, **kwargs):
   elif deps:
     fail("kwarg does nothing when binary is specified", "deps")
 
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, binary=binary, layers=layers,

java/image.bzl

@@ -238,13 +238,11 @@ def java_image(name, base=None, main_class=None,
                      deps=(deps + layers) or None, runtime_deps=runtime_deps,
                      jvm_flags=jvm_flags, **kwargs)
 
-  index = 0
   base = base or DEFAULT_JAVA_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     jar_dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   jar_app_layer(name=name, base=base, binary=binary_name,
@@ -353,13 +351,11 @@ def war_image(name, base=None, deps=[], layers=[], **kwargs):
 
   native.java_library(name=library_name, deps=deps + layers, **kwargs)
 
-  index = 0
   base = base or DEFAULT_JETTY_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     _war_dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   _war_app_layer(name=name, base=base, library=library_name, layers=layers,

nodejs/image.bzl

@@ -122,13 +122,11 @@ def nodejs_image(name, base=None, data=[], layers=[],
 
   # TODO(mattmoor): Consider making the directory into which the app
   # is placed configurable.
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     _dep_layer(name=this_name, base=base, dep=dep, binary=binary_name)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, entrypoint=['sh', '-c'],

python/image.bzl

@@ -74,13 +74,11 @@ def py_image(name, base=None, deps=[], layers=[], **kwargs):
 
   # TODO(mattmoor): Consider making the directory into which the app
   # is placed configurable.
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, entrypoint=['/usr/bin/python'],

python3/image.bzl

@@ -74,13 +74,11 @@ def py3_image(name, base=None, deps=[], layers=[], **kwargs):
 
   # TODO(mattmoor): Consider making the directory into which the app
   # is placed configurable.
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, entrypoint=['/usr/bin/python'],

rust/image.bzl

@@ -49,13 +49,11 @@ def rust_image(name, base=None, deps=[], layers=[], binary=None, **kwargs):
   elif deps:
     fail("kwarg does nothing when binary is specified", "deps")
 
-  index = 0
   base = base or DEFAULT_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s_%d" % (name, index)
     dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   app_layer(name=name, base=base, binary=binary, layers=layers,

scala/image.bzl

@@ -47,13 +47,11 @@ def scala_image(name, base=None, main_class=None,
                       deps=(deps + layers) or None, runtime_deps=runtime_deps,
                       jvm_flags=jvm_flags, **kwargs)
 
-  index = 0
   base = base or DEFAULT_JAVA_BASE
-  for dep in layers:
+  for index, dep in enumerate(layers):
     this_name = "%s.%d" % (name, index)
     jar_dep_layer(name=this_name, base=base, dep=dep)
     base = this_name
-    index += 1
 
   visibility = kwargs.get('visibility', None)
   jar_app_layer(name=name, base=base, binary=binary_name,