Added Andrea to maintainers list +1 (Apicurio#4042)

* Added Andrea to maintainers list. Fixed a bug in the H2 SQL queries * Change getNextSequenceValue() for h2 to RT exception since it should not be called.
mimaison · Nov 30, 2023 · d5b678c · d5b678c
1 parent 2750eaf
commit d5b678c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java b/app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java
@@ -3363,7 +3363,7 @@ private long nextSequenceValue(String sequenceName) {
                         .one(); // TODO Handle non-existing sequence (see resetSequence)
             } else {
                 // no way to automatically increment the sequence in h2 with just one query
-                // we are incresing the sequence value in a way that it's not safe for concurrent executions
+                // we are increasing the sequence value in a way that it's not safe for concurrent executions
                 // for kafkasql storage this method is not supposed to be executed concurrently
                 // but for inmemory storage that's not guaranteed
                 // that forces us to use an inmemory lock, should not cause any harm

diff --git a/app/src/main/java/io/apicurio/registry/storage/impl/sql/H2SqlStatements.java b/app/src/main/java/io/apicurio/registry/storage/impl/sql/H2SqlStatements.java
@@ -74,7 +74,7 @@ public String upsertContent() {
      */
     @Override
     public String getNextSequenceValue() {
-        return "UPDATE sequences sa SET seq_value = (SELECT sb.seq_value + 1 FROM sequences sb WHERE sb.name = sa.name) WHERE sa.tenantId = ? AND sa.name = ?";
+        throw new RuntimeException("Not applicable when using H2 as the database kind.");
     }
 
     /**

diff --git a/pom.xml b/pom.xml
@@ -45,7 +45,7 @@
                 <role>Project Lead</role>
                 <role>Developer</role>
             </roles>
-            <timezone>-5</timezone>
+            <timezone>America/New_York</timezone>
         </developer>
         <developer>
             <name>Jakub Senko</name>
@@ -55,7 +55,7 @@
             <roles>
                 <role>Developer</role>
             </roles>
-            <timezone>+1</timezone>
+            <timezone>Europe/Prague</timezone>
         </developer>
         <developer>
             <name>Carles Arnal</name>
@@ -65,7 +65,17 @@
             <roles>
                 <role>Developer</role>
             </roles>
-            <timezone>+1</timezone>
+            <timezone>Europe/Madrid</timezone>
+        </developer>
+        <developer>
+            <name>Andrea Peruffo</name>
+            <id>andreaTP</id>
+            <email>[email protected]</email>
+            <organization>Red Hat</organization>
+            <roles>
+                <role>Developer</role>
+            </roles>
+            <timezone>Europe/Lisbon</timezone>
         </developer>
     </developers>