Skip to content

Commit

Permalink
build: re-enable revive linters
Browse files Browse the repository at this point in the history
In this commit:

75dfdbf ci: revert revive settings back to fix lint

We accidentally disabled all the revive linters. Unfortunately setting
the rules clears the default set of rules so it is necessary to
mention all rules that we need.
  • Loading branch information
ncw committed Aug 29, 2023
1 parent 967fc6d commit feaa20d
Showing 1 changed file with 48 additions and 4 deletions.
52 changes: 48 additions & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,67 @@ issues:
- staticcheck
text: 'SA1019: "github.com/rclone/rclone/cmd/serve/httplib" is deprecated'

# don't disable the revive messages about comments on exported functions
include:
- EXC0012
- EXC0013
- EXC0014
- EXC0015

run:
# timeout for analysis, e.g. 30s, 5m, default is 1m
timeout: 10m

linters-settings:
revive:
# setting rules seems to disable all the rules, so re-enable them here
rules:
- name: unreachable-code
disabled: true
- name: unused-parameter
disabled: true
- name: blank-imports
disabled: false
- name: context-as-argument
disabled: false
- name: context-keys-type
disabled: false
- name: dot-imports
disabled: false
- name: empty-block
disabled: true
- name: error-naming
disabled: false
- name: error-return
disabled: false
- name: error-strings
disabled: false
- name: errorf
disabled: false
- name: exported
disabled: false
- name: increment-decrement
disabled: true
- name: indent-error-flow
disabled: false
- name: package-comments
disabled: false
- name: range
disabled: false
- name: receiver-naming
disabled: false
- name: redefines-builtin-id
disabled: true
- name: superfluous-else
disabled: true
- name: time-naming
disabled: false
- name: unexported-return
disabled: false
- name: unreachable-code
disabled: true
- name: unused-parameter
disabled: true
- name: var-declaration
disabled: false
- name: var-naming
disabled: false
stylecheck:
# Only enable the checks performed by the staticcheck stand-alone tool,
# as documented here: https://staticcheck.io/docs/configuration/options/#checks
Expand Down

0 comments on commit feaa20d

Please sign in to comment.