Skip to content

Commit

Permalink
[AIRFLOW-556] Add UI PR guidelines
Browse files Browse the repository at this point in the history
For all PRs with UI changes, it is a requirement
that screenshots be included in the PR. Update
PULL_REQUEST_TEMPLATE with this PR guideline for
UI changes.

Closes apache#1829 from r39132/master
  • Loading branch information
r39132 committed Oct 6, 2016
1 parent 4405940 commit 99e7d8c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,15 @@ Reminders for contributors (REQUIRED!):
[Airflow's JIRA](https://issues.apache.org/jira/browse/AIRFLOW/).
For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
issue #1. Please open a new issue if required!

* For all PRs with UI changes, you must provide screenshots. If the UI changes are not obvious, either annotate the images or provide before/after screenshots.

* Please squash your commits when possible and follow the [How to write a good git commit message](http://chris.beams.io/posts/git-commit/).
Summarized as follows:
1. Separate subject from body with a blank line
2. Limit the subject line to 50 characters
3. Do not end the subject line with a period
4. Use the imperative mood in the subject line (add, not adding)
5. Wrap the body at 72 characters
6. Use the body to explain what and why vs. how
6. Use the body to explain what and why vs. how

0 comments on commit 99e7d8c

Please sign in to comment.