Skip to content

Commit

Permalink
[cleanup] Misc
Browse files Browse the repository at this point in the history
  • Loading branch information
pukkandan committed Jul 30, 2022
1 parent daef791 commit 31b532a
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 20 deletions.
29 changes: 15 additions & 14 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
### Description of your *pull request* and other information

</details>

<!--
Explanation of your *pull request* in arbitrary form goes here. Please **make sure the description explains the purpose and effect** of your *pull request* and is worded well enough to be understood. Provide as much **context and examples** as possible
-->

ADD DESCRIPTION HERE

Fixes #


<details open><summary>Template</summary> <!-- OPEN is intentional -->

<!--
Expand All @@ -24,17 +39,3 @@
- [ ] New extractor ([Piracy websites will not be accepted](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy))
- [ ] Core bug fix/improvement
- [ ] New feature (It is strongly [recommended to open an issue first](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#adding-new-feature-or-making-overarching-changes))

### Description of your *pull request* and other information

</details>

<!--
Explanation of your *pull request* in arbitrary form goes here. Please **make sure the description explains the purpose and effect** of your *pull request* and is worded well enough to be understood. Provide as much **context and examples** as possible
-->

DESCRIPTION

Fixes #
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ After you have ensured this site is distributing its content legally, you can fo

$ flake8 yt_dlp/extractor/yourextractor.py

1. Make sure your code works under all [Python](https://www.python.org/) versions supported by yt-dlp, namely CPython and PyPy for Python 3.6 and above. Backward compatibility is not required for even older versions of Python.
1. Make sure your code works under all [Python](https://www.python.org/) versions supported by yt-dlp, namely CPython and PyPy for Python 3.7 and above. Backward compatibility is not required for even older versions of Python.
1. When the tests pass, [add](https://git-scm.com/docs/git-add) the new files, [commit](https://git-scm.com/docs/git-commit) them and [push](https://git-scm.com/docs/git-push) the result, like this:

$ git add yt_dlp/extractor/_extractors.py
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ setenv =


[isort]
py_version = 36
py_version = 37
multi_line_output = VERTICAL_HANGING_INDENT
line_length = 80
reverse_relative = true
Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
except ImportError:
try:
from Crypto.Cipher import AES as Cryptodome_AES
except ImportError:
except (ImportError, SyntaxError): # Old Crypto gives SyntaxError in newer Python
Cryptodome_AES = None
else:
try:
Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/extractor/minds.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def _real_extract(self, url):
else:
return self.url_result(entity['perma_url'])
else:
assert(entity['subtype'] == 'video')
assert entity['subtype'] == 'video'
video_id = entity_id
# 1080p and webm formats available only on the sources array
video = self._call_api(
Expand Down
3 changes: 1 addition & 2 deletions yt_dlp/extractor/youtube.py
Original file line number Diff line number Diff line change
Expand Up @@ -3562,8 +3562,7 @@ def feed_entry(name):

formats.extend(self._extract_storyboard(player_responses, duration))

# Source is given priority since formats that throttle are given lower source_preference
# When throttling issue is fully fixed, remove this
# source_preference is lower for throttled/potentially damaged formats
self._sort_formats(formats, ('quality', 'res', 'fps', 'hdr:12', 'source', 'codec:vp9.2', 'lang', 'proto'))

info = {
Expand Down

0 comments on commit 31b532a

Please sign in to comment.