Skip to content

Commit

Permalink
Move lib/ofp-errors.h to include/openvswitch directory
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Warren <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
Ben Warren authored and blp committed Mar 19, 2016
1 parent b211014 commit e03c096
Show file tree
Hide file tree
Showing 30 changed files with 32 additions and 32 deletions.
2 changes: 1 addition & 1 deletion FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,7 @@ A: This is a Open vSwitch extension to OpenFlow error codes. Open
If you want to dissect the extended error message yourself, the
format is documented in include/openflow/nicira-ext.h in the Open
vSwitch source distribution. The extended error codes are
documented in lib/ofp-errors.h.
documented in include/openvswitch/ofp-errors.h.

Q1: Some of the traffic that I'd expect my OpenFlow controller to see
doesn't actually appear through the OpenFlow connection, even
Expand Down
2 changes: 1 addition & 1 deletion build-aux/extract-ofp-errors
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ experimenter IDs), then ERROR_HEADER to obtain OpenFlow error number.
It outputs a C source file for translating OpenFlow error codes into
strings.
ERROR_HEADER should point to lib/ofp-errors.h.
ERROR_HEADER should point to include/openvswitch/ofp-errors.h.
VENDOR_HEADER should point to include/openflow/openflow-common.h.
The output is suitable for use as lib/ofp-errors.inc.\
''' % {"argv0": argv0})
Expand Down
1 change: 1 addition & 0 deletions include/openvswitch/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ openvswitchinclude_HEADERS = \
include/openvswitch/compiler.h \
include/openvswitch/geneve.h \
include/openvswitch/list.h \
include/openvswitch/ofp-errors.h \
include/openvswitch/thread.h \
include/openvswitch/token-bucket.h \
include/openvswitch/types.h \
Expand Down
4 changes: 2 additions & 2 deletions lib/ofp-errors.h → include/openvswitch/ofp-errors.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#ifndef OFP_ERRORS_H
#define OFP_ERRORS_H 1
#ifndef OPENVSWITCH_OFP_ERRORS_H
#define OPENVSWITCH_OFP_ERRORS_H 1

#include <stdbool.h>
#include <stddef.h>
Expand Down
5 changes: 2 additions & 3 deletions lib/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ lib_libopenvswitch_la_SOURCES = \
lib/ofp-actions.c \
lib/ofp-actions.h \
lib/ofp-errors.c \
lib/ofp-errors.h \
lib/ofp-msgs.c \
lib/ofp-msgs.h \
lib/ofp-parse.c \
Expand Down Expand Up @@ -494,10 +493,10 @@ lib/ofp-actions.lo: lib/ofp-actions.inc1 lib/ofp-actions.inc2
CLEANFILES += lib/ofp-actions.inc1 lib/ofp-actions.inc2
EXTRA_DIST += build-aux/extract-ofp-actions

lib/ofp-errors.inc: lib/ofp-errors.h include/openflow/openflow-common.h \
lib/ofp-errors.inc: include/openvswitch/ofp-errors.h include/openflow/openflow-common.h \
$(srcdir)/build-aux/extract-ofp-errors
$(AM_V_GEN)$(run_python) $(srcdir)/build-aux/extract-ofp-errors \
$(srcdir)/lib/ofp-errors.h \
$(srcdir)/include/openvswitch/ofp-errors.h \
$(srcdir)/include/openflow/openflow-common.h > $@.tmp && \
mv $@.tmp $@
lib/ofp-errors.lo: lib/ofp-errors.inc
Expand Down
2 changes: 1 addition & 1 deletion lib/bundle.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
#include "nx-match.h"
#include "ofpbuf.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "openflow/nicira-ext.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"

VLOG_DEFINE_THIS_MODULE(bundle);
Expand Down
2 changes: 1 addition & 1 deletion lib/bundle.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
#include <stdint.h>

#include "compiler.h"
#include "ofp-errors.h"
#include "openflow/nicira-ext.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"

struct ds;
Expand Down
2 changes: 1 addition & 1 deletion lib/dpif.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "netlink.h"
#include "odp-execute.h"
#include "odp-util.h"
#include "ofp-errors.h"
#include "ofp-print.h"
#include "ofp-util.h"
#include "ofpbuf.h"
Expand All @@ -49,6 +48,7 @@
#include "util.h"
#include "uuid.h"
#include "valgrind.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"

VLOG_DEFINE_THIS_MODULE(dpif);
Expand Down
2 changes: 1 addition & 1 deletion lib/learn.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
#include "meta-flow.h"
#include "nx-match.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "ofpbuf.h"
#include "openflow/openflow.h"
#include "openvswitch/ofp-errors.h"
#include "unaligned.h"


Expand Down
2 changes: 1 addition & 1 deletion lib/learn.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#define LEARN_H 1

#include "compiler.h"
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"

struct ds;
struct flow;
Expand Down
2 changes: 1 addition & 1 deletion lib/learning-switch.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "mac-learning.h"
#include "ofpbuf.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-parse.h"
#include "ofp-print.h"
Expand All @@ -42,6 +41,7 @@
#include "shash.h"
#include "simap.h"
#include "timeval.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vconn.h"
#include "openvswitch/vlog.h"

Expand Down
2 changes: 1 addition & 1 deletion lib/meta-flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "classifier.h"
#include "dynamic-string.h"
#include "nx-match.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "ovs-thread.h"
#include "packets.h"
Expand All @@ -36,6 +35,7 @@
#include "tun-metadata.h"
#include "unaligned.h"
#include "util.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"

VLOG_DEFINE_THIS_MODULE(meta_flow);
Expand Down
2 changes: 1 addition & 1 deletion lib/meta-flow.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include <netinet/ip6.h>
#include "bitmap.h"
#include "flow.h"
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"
#include "packets.h"
#include "util.h"

Expand Down
2 changes: 1 addition & 1 deletion lib/multipath.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
#include "dynamic-string.h"
#include "nx-match.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "openvswitch/ofp-errors.h"
#include "openflow/nicira-ext.h"
#include "packets.h"

Expand Down
2 changes: 1 addition & 1 deletion lib/multipath.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

#include <stdint.h>
#include "compiler.h"
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"

struct ds;
struct flow;
Expand Down
2 changes: 1 addition & 1 deletion lib/nx-match.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "hmap.h"
#include "meta-flow.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "ofpbuf.h"
#include "openflow/nicira-ext.h"
Expand All @@ -35,6 +34,7 @@
#include "tun-metadata.h"
#include "unaligned.h"
#include "util.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"

VLOG_DEFINE_THIS_MODULE(nx_match);
Expand Down
2 changes: 1 addition & 1 deletion lib/nx-match.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "compiler.h"
#include "flow.h"
#include "meta-flow.h"
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"

struct ds;
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-actions.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
#include <stddef.h>
#include <stdint.h>
#include "meta-flow.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "openflow/openflow.h"
#include "openflow/nicira-ext.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"

/* List of OVS abstracted actions.
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-errors.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
*/

#include <config.h>
#include "ofp-errors.h"
#include <errno.h>
#include "byte-order.h"
#include "dynamic-string.h"
#include "ofp-msgs.h"
#include "ofp-util.h"
#include "ofpbuf.h"
#include "openflow/openflow.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"

VLOG_DEFINE_THIS_MODULE(ofp_errors);
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-msgs.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
* of headers.
*/

#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"
#include "ofp-errors.h"
#include "util.h"

struct ovs_list;
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-print.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
#include "nx-match.h"
#include "ofp-actions.h"
#include "ofpbuf.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-util.h"
#include "openflow/openflow.h"
#include "openflow/nicira-ext.h"
#include "openvswitch/ofp-errors.h"
#include "packets.h"
#include "dp-packet.h"
#include "type-props.h"
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-prop.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#include "byte-order.h"
#include "ofpbuf.h"
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"
#include "util.h"
#include "uuid.h"
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-prop.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"

struct ofpbuf;
Expand Down
2 changes: 1 addition & 1 deletion lib/ofp-util.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "nx-match.h"
#include "id-pool.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-prop.h"
#include "ofp-util.h"
Expand All @@ -46,6 +45,7 @@
#include "tun-metadata.h"
#include "unaligned.h"
#include "type-props.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"
#include "bitmap.h"

Expand Down
2 changes: 1 addition & 1 deletion lib/pktbuf.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <stddef.h>
#include <stdint.h>

#include "ofp-errors.h"
#include "openvswitch/ofp-errors.h"

struct pktbuf;
struct dp_packet;
Expand Down
2 changes: 1 addition & 1 deletion lib/vconn.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "dynamic-string.h"
#include "fatal-signal.h"
#include "flow.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-print.h"
#include "ofp-util.h"
Expand All @@ -37,6 +36,7 @@
#include "poll-loop.h"
#include "random.h"
#include "util.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"
#include "socket-util.h"

Expand Down
2 changes: 1 addition & 1 deletion ofproto/connmgr.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
#include "hmap.h"
#include "list.h"
#include "match.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "ofproto.h"
#include "ofproto-provider.h"
#include "openflow/nicira-ext.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/types.h"

struct nlattr;
Expand Down
2 changes: 1 addition & 1 deletion ofproto/ofproto-provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
#include "hindex.h"
#include "list.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-util.h"
#include "ofproto/ofproto.h"
#include "openvswitch/ofp-errors.h"
#include "ovs-atomic.h"
#include "ovs-rcu.h"
#include "ovs-thread.h"
Expand Down
2 changes: 1 addition & 1 deletion ofproto/ofproto.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "netdev.h"
#include "nx-match.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-print.h"
#include "ofp-util.h"
Expand All @@ -59,6 +58,7 @@
#include "tun-metadata.h"
#include "unaligned.h"
#include "unixctl.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vlog.h"
#include "bundles.h"

Expand Down
2 changes: 1 addition & 1 deletion utilities/ovs-ofctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
#include "nx-match.h"
#include "odp-util.h"
#include "ofp-actions.h"
#include "ofp-errors.h"
#include "ofp-msgs.h"
#include "ofp-parse.h"
#include "ofp-print.h"
Expand All @@ -61,6 +60,7 @@
#include "timeval.h"
#include "unixctl.h"
#include "util.h"
#include "openvswitch/ofp-errors.h"
#include "openvswitch/vconn.h"
#include "openvswitch/vlog.h"
#include "meta-flow.h"
Expand Down

0 comments on commit e03c096

Please sign in to comment.