Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize and make uniform all source formatting #8

Merged
merged 7 commits into from
Jan 16, 2019

Conversation

karlstolley
Copy link
Member

This is a way bigger and way more boring PR than ordinarily I'll make. I've just cleaned up all of the source in the core Ed files, so that those kinds of fixes don't muddy the waters on future commits where I'm actually changing the code base in meaningful ways.

In all cases, I've stripped all trailing whitespace, and made sure that all files end with a newline character, so that they'll play more nicely with git diff.

There are details that might be worth checking out in the commit messages in all seven commits below. I'll be adding their contents and formatted examples to the dev documentation wiki.

* Convert any tabs to spaces (in keeping with Ruby style)
* Remove trailing whitespace
* Add trailing space to end of files where it was lacking (Git-friendly)
Multiline:
* 1 line before
* No lines after
* Text indented 2 spaces and wrapped to 100 characters

Single line:
* 1 line before
* No lines after
* Space between dashes and text
Multiline:
* 2 lines before
* 1 line after
* Lines wraped to 100 characters
* No asterisks before wrapped lines
* Two spaces before each line
* Comment opens on line above text
* Comment closes on line below text

Single line:
* 1 line before
* No line after
* Lines wrapped to 100 characters
* Single space between asterisk and text
Multiline & single line:
* 1 line before outside of blocks
* No lines before inside of blocks
* No lines after
* Use double-slash style for all comments
* Space between double slash and text
* Lines wrapped to 100 characters
Multiline & single line:
* 1 line before
* No lines after
* Lines wrapped to 100 characters
That is, ensure a space between the closing quotation mark on attributes
before the void (self-closing) `/>`.
* Two spaces of indent inside declaration block
* Additional two spaces of indent inside media queries
* One line of space between style declarations
* Combined selectors appear one selector per line
@elotroalex elotroalex merged commit ca45b08 into minicomp:master Jan 16, 2019
@karlstolley karlstolley deleted the source-formatting branch January 17, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants