MINOR: Add some logging for the transaction coordinator

Author: Apurva Mehta <[email protected]> Reviewers: Guozhang Wang <[email protected]>, Jason Gustafson <[email protected]> Closes apache#3278 from apurvam/MINOR-add-logging-to-transaction-coordinator-in-all-failure-cases
minleuk · Jun 20, 2017 · cb2fdbd · cb2fdbd
1 parent 1d24e10
commit cb2fdbd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala b/core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
@@ -400,7 +400,6 @@ class TransactionCoordinator(brokerId: Int,
               preSendResult match {
                 case Left(err) =>
                   info(s"Aborting sending of transaction markers after appended $txnMarkerResult to transaction log and returning $err error to client for $transactionalId's EndTransaction request")
-
                   responseCallback(err)
 
                 case Right((txnMetadata, newPreSendMetadata)) =>
@@ -435,7 +434,7 @@ class TransactionCoordinator(brokerId: Int,
         TransactionResult.ABORT,
         (error: Errors) => error match {
           case Errors.NONE =>
-            debug(s"Completed rollback ongoing transaction of transactionalId: ${txnIdAndPidEpoch.transactionalId} due to timeout")
+            info(s"Completed rollback ongoing transaction of transactionalId: ${txnIdAndPidEpoch.transactionalId} due to timeout")
           case Errors.INVALID_PRODUCER_ID_MAPPING |
                Errors.INVALID_PRODUCER_EPOCH |
                Errors.CONCURRENT_TRANSACTIONS =>

diff --git a/.../main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala b/.../main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala
@@ -182,7 +182,7 @@ class TransactionMarkerRequestCompletionHandler(brokerId: Int,
 
             if (!abortSending) {
               if (retryPartitions.nonEmpty) {
-                trace(s"Re-enqueuing ${txnMarker.transactionResult} transaction markers for transactional id $transactionalId " +
+                debug(s"Re-enqueuing ${txnMarker.transactionResult} transaction markers for transactional id $transactionalId " +
                   s"under coordinator epoch ${txnMarker.coordinatorEpoch}")
 
                 // re-enqueue with possible new leaders of the partitions

diff --git a/core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala b/core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
@@ -506,7 +506,6 @@ class TransactionStateManager(brokerId: Int,
             info(s"Accessing the cached transaction metadata for $transactionalId returns $err error; " +
               s"aborting transition to the new metadata and setting the error in the callback")
             responseError = err
-
           case Right(Some(epochAndMetadata)) =>
             val metadata = epochAndMetadata.transactionMetadata