Skip to content

Commit

Permalink
Merge pull request kubernetes#1695 from guineveresaenger/brokenlink
Browse files Browse the repository at this point in the history
fixed links to community expectations
  • Loading branch information
k8s-ci-robot authored Jan 26, 2018
2 parents ca503d1 + ec8afcb commit c41473c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Links in [contributors/devel/README.md](contributors/devel/README.md)
lead to many relevant topics, including
* [Developer's Guide] - how to start a build/test cycle
* [Collaboration Guide] - how to work together
* [expectations] - what the community expects
* [expectations](contributors/guide/community-expectations) - what the community expects
* [pull request] policy - how to prepare a pull request

## Your First Contribution
Expand Down
2 changes: 1 addition & 1 deletion community-membership.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ The following apply to the part of codebase for which one would be an approver i
- Demonstrate sound technical judgement
- Responsible for project quality control via [code reviews](contributors/devel/collab.md)
- Focus on holistic acceptance of contribution such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, etc
- Expected to be responsive to review requests as per [community expectations](contributors/devel/community-expectations.md);
- Expected to be responsive to review requests as per [community expectations](contributors/guide/community-expectations.md);
- Mentor contributors and reviewers
- May approve code contributions for acceptance

Expand Down
2 changes: 1 addition & 1 deletion contributors/guide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ The pull request workflow is described in detail [here](/contributors/devel/pull

## Code Review

For a brief description of the importance of code review, please read [On Code Review](/contributors/devel/community-expectations.md#code-review). There are two aspects of code review: giving and receiving.
For a brief description of the importance of code review, please read [On Code Review](/contributors/guide/community-expectations.md#code-review). There are two aspects of code review: giving and receiving.

To make it easier for your PR to receive reviews, consider the reviewers will need you to:

Expand Down
2 changes: 1 addition & 1 deletion mentoring/group-mentee-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Suggested Activity
- the docs
- k/community is your friend for upstream workflows, processes, and information around contributing
- This repo includes the community/devel folder which will be extra helpful that includes docs such as:
- [Code Review Expectations](/contributors/devel/community-expectations.md)
- [Code Review Expectations](/contributors/guide/community-expectations.md)
- [Collaboration on k8s](/contributors/devel/collab.md)


Expand Down

0 comments on commit c41473c

Please sign in to comment.