Skip to content

Commit

Permalink
Get rid of the "Skipped X files" messages from isort output.
Browse files Browse the repository at this point in the history
isort skips __init__.py by default, leading to these confusing messages:
The casual reader will wonder what got skipped, and why, and whether it's OK.

This change to our .isort.cfg files ensures that isort doesn't skip
__init__.py files.  All ours are empty anyway, so isort will do nothing
with them, but this gets rid of those distracting messages.

Testing Done:
CI passed: https://travis-ci.org/pantsbuild/pants/builds/167197899

Reviewed at https://rbcommons.com/s/twitter/r/4301/
  • Loading branch information
benjyw committed Oct 13, 2016
1 parent 7f54e2b commit 3f3abd9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .isort.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ indent=2
lines_after_imports=2
known_first_party=internal_backend,pants,pants_test
default_section=THIRDPARTY
not_skip=__init__.py
1 change: 1 addition & 0 deletions contrib/.isort.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ indent=2
lines_after_imports=2
known_first_party=pants.contrib
default_section=THIRDPARTY
not_skip=__init__.py
1 change: 1 addition & 0 deletions examples/.isort.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ indent=2
lines_after_imports=2
known_first_party=example
default_section=THIRDPARTY
not_skip=__init__.py

0 comments on commit 3f3abd9

Please sign in to comment.