Set axes color and added AxesTextColor property #3316
Conversation
|
Can one of the admins verify this patch? |
| @@ -47,6 +47,7 @@ open class AxisChartView : ChartView { | |||
| (chart as? BarLineChartViewBase)?.leftAxis.granularity = 1 | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We probably don't need an extra blank line.
|
Some todos once this is further along:
|
ghu999
force-pushed
the
feature-axestextcolor
branch
from
0b7d115 to
a2bc8c9
Compare
…Color and dataLabelColor
| @@ -47,6 +47,7 @@ open class AxisChartView : ChartView { | |||
| (chart as? BarLineChartViewBase)?.leftAxis.granularity = 1 | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please reset this file as mentioned.
| @@ -99,6 +99,7 @@ public void setColor(int argb) { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please reset this file since this is a whitespace only change.
There was a problem hiding this comment.
It looks like you need to add the function for upgrading the ChartData2D component.
| return colorToArgb(_axesTextColor) | ||
| } | ||
| set { | ||
| _axesTextColor = argbToColor(newValue) |
There was a problem hiding this comment.
Make sure to appropriately handle if newValue is COLOR_DEFAULT, which itself is a 0-alpha value that would otherwise make the text invisible.
| @@ -12,6 +12,8 @@ import DGCharts | |||
| var _color: Int32 = AIComponentKit.Color.black.int32 | |||
| var _colors: [UIColor] = [] | |||
| var _label: String? | |||
|
|
|||
| var _dataLabelColor: Int32 = AIComponentKit.Color.black.int32 | |||
There was a problem hiding this comment.
Do we need to make this conditional on dark theme similar to what you did in Chart.swift?
There was a problem hiding this comment.
We will need to reset this since the change is already in ucr.
| @@ -51,4 +53,14 @@ protected void initializeDefaultSettings() { | |||
| public View getView() { | |||
| return chart; | |||
| } | |||
| /** | |||
There was a problem hiding this comment.
Code style: Include a blank line before the Javadoc to visually separate it from the previous function body.
| @@ -57,6 +61,8 @@ protected ChartDataBase(Chart chartContainer) { | |||
| Color(Component.COLOR_BLACK); | |||
| DataSourceKey(""); | |||
| Label(""); | |||
|
|
|||
| DataLabelColor(Component.COLOR_BLACK); | |||
There was a problem hiding this comment.
See my note on the iOS version about whether we need to adjust this for dark theme.
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
Fixes # .
Resolves # .