-
Notifications
You must be signed in to change notification settings - Fork 6
Issues: mit6005/S13-R08-12noon-indigo
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
In the Instrument enum: I think STEAL_DRUMS should be STEEL_DRUMS
#12
by benbitdiddle
was closed May 2, 2013
Concat should have a getter method 'second' that returns the second music (like 'first' returns first)
#11
by benbitdiddle
was closed May 2, 2013
Note has a rep invariant that pitch is not null, but Note.checkRep doesn't assert that, it should
#10
by benbitdiddle
was closed May 2, 2013
Concat.checkRep is not implemented, it's supposed to check that first and second are not null
#9
by benbitdiddle
was closed May 2, 2013
Note.equals returns true if we call it with null; should be false!
#8
by benbitdiddle
was closed May 2, 2013
The Note.testNote method was just for testing, it should be removed
#7
by benbitdiddle
was closed May 2, 2013
Pitch.difference is backwards, subtraction needs to be reversed in order to return the specified value
#6
by benbitdiddle
was closed May 2, 2013
Concat.duration returns the wrong value, only looks at the first music duration, should be the sum
#5
by benbitdiddle
was closed May 2, 2013
Pitch has the wrong value for OCTAVE, there are 12 semitones in an octave
#3
by benbitdiddle
was closed May 2, 2013
SequencePlayer.main doesn't compile, needs to throw MidiUnavailableException and InvalidMidiDataException
#2
by benbitdiddle
was closed May 2, 2013
SequencePlayer.main test scale ends with the wrong note, should be C
#1
by benbitdiddle
was closed May 2, 2013
ProTip!
Adding no:label will show everything without a label.