Skip to content

Commit

Permalink
✅ Green CI: Fix JavaScript e2e tests, disable failing Android e2e test (
Browse files Browse the repository at this point in the history
facebook#28392)

Summary:
Jobs now have a `run_disabled_tests` argument that allows for the selective execution of disabled tests. When working on re-enabling a failing test, the contributor just needs to set `run_disabled_tests` to `true` in the appropriate workflow in `.circleci/config.yml`.

Tests can be kept green by moving failing tests into the disabled section until a contributor can provide a fix, thus ensuring signal is maintained on master. For example, a failing end-to-end test might be disabled in order to allow the signal from unit tests to be provided, as opposed to flat out failing the entire job.

What was done in this PR:
* The failing `test_js_e2e` job has been fixed, and merged into the `test_js` job. An empty disabled tests section is added for future use.
* The failing `test_ios_e2e` job has been merged into `test_ios`, with all of its steps gated behind the `run_disabled_steps` argument.
* The failing Android end-to-end tests have been added to `test_android`, gated behind the `run_disabled_steps` argument
* The failing Podspecs test has been added back into `test_ios`, gated behind the `run_disabled_steps` argument

## Changelog

[Internal] [CI] - ✅ Green CI, disabled test infrastructure work
Pull Request resolved: facebook#28392

Test Plan: Verified on Circle CI

Reviewed By: cpojer

Differential Revision: D20665512

Pulled By: hramos

fbshipit-source-id: 831738027f90f4b23313893d8342d7e654f34726
  • Loading branch information
hramos authored and facebook-github-bot committed Mar 26, 2020
1 parent ec2cfe9 commit 8ac00b3
Show file tree
Hide file tree
Showing 2 changed files with 127 additions and 133 deletions.
Loading

0 comments on commit 8ac00b3

Please sign in to comment.