Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to Qt 5.12.5 fixes a crash on macOS that can be reproduced using the current Mixxx 2.4 tree by:
(Only Mixxx 2.4 seems to be affected, on arm64 and x86_64 macOS, not however Mixxx 2.3). Updating to Qt 5.12.5 seems to fix the issue and doesn't incur the waveform performance regressions that currently prevent us from upgrading to newer Qt versions.
Still, it would probably be good to extensively test Mixxx on Qt 5.12.5 before merging, therefore I'll mark this as draft for now.