Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-base] Use Qt 5.12.5 #53

Merged
merged 1 commit into from
Nov 1, 2022
Merged

[qt5-base] Use Qt 5.12.5 #53

merged 1 commit into from
Nov 1, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Oct 18, 2022

Updating to Qt 5.12.5 fixes a crash on macOS that can be reproduced using the current Mixxx 2.4 tree by:

(Only Mixxx 2.4 seems to be affected, on arm64 and x86_64 macOS, not however Mixxx 2.3). Updating to Qt 5.12.5 seems to fix the issue and doesn't incur the waveform performance regressions that currently prevent us from upgrading to newer Qt versions.

Still, it would probably be good to extensively test Mixxx on Qt 5.12.5 before merging, therefore I'll mark this as draft for now.

@fwcd
Copy link
Member Author

fwcd commented Oct 18, 2022

It seems as if 5.12.5 is the last version that doesn't regress waveform performance. Here's two builds for arm64 macOS, the former runs smoothly, the latter does not:

@daschuer
Copy link
Member

@m0dB: can you confirm this?

@m0dB
Copy link

m0dB commented Oct 19, 2022

@daschuer I don't have a arm64 mac, so I can't confirm this.

@fwcd
Copy link
Member Author

fwcd commented Oct 19, 2022

I've started an x86_64 build using Qt 5.12.5 in CI here: https://github.com/fwcd/m1xxx/actions/runs/3281427824/jobs/5403421350

@fwcd
Copy link
Member Author

fwcd commented Oct 20, 2022

@m0dB Could you check whether that build runs fine for you? Under Rosetta it seems to run smoothly

@m0dB
Copy link

m0dB commented Oct 21, 2022

Yes, I would say it runs comparable to the official 2.3.3.

@fwcd fwcd marked this pull request as ready for review October 23, 2022 11:48
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit e22e627 into mixxxdj:2.4 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants