-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modelbench SUT cleanup + testing infra improvements #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 22:36 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 22:36 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 22:36 — with
GitHub Actions
Inactive
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having an easy-to-read sut ID list would be super nice.
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 23:43 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 23:43 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 16, 2024 23:43 — with
GitHub Actions
Inactive
Merged
rogthefrog
approved these changes
Dec 17, 2024
bkorycki
temporarily deployed
to
Scheduled Testing
December 18, 2024 20:48 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 18, 2024 20:48 — with
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
December 18, 2024 20:48 — with
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some initial improvements along the road to removing the SUT wrapper class in modelbench. I'm splitting the changes up into smaller PRs to make the more manageable to review.
Changes in this PR:
--sut <uid>
arg when running the CLI.