Fixes zammad#4413 - Overview ticket preview should also load on saved…

… objects.
mlefrancois19 · Dec 5, 2022 · 3685ff7 · 3685ff7
1 parent 71c00f2
commit 3685ff7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/app/assets/javascripts/app/controllers/_ui_element/_application_selector.coffee b/app/assets/javascripts/app/controllers/_ui_element/_application_selector.coffee
@@ -287,6 +287,9 @@ class App.UiElement.ApplicationSelector
     @disableRemoveForOneAttribute(item)
     @saveParams(item)
 
+    if attribute.preview isnt false
+      @preview(item)
+
     item
 
   @renderParamValue: (item, attribute, params, paramValue) ->

diff --git a/app/assets/javascripts/app/controllers/_ui_element/ticket_selector.coffee b/app/assets/javascripts/app/controllers/_ui_element/ticket_selector.coffee
@@ -306,6 +306,9 @@ class App.UiElement.ticket_selector extends App.UiElement.ApplicationSelector
 
     @applySortable(item, attribute, params)
 
+    if attribute.preview isnt false
+      @preview(item)
+
     item
 
   @saveParams: (item, params, attribute) ->

diff --git a/spec/system/manage/overviews_spec.rb b/spec/system/manage/overviews_spec.rb
@@ -186,11 +186,6 @@
           within '.table-overview .js-tableBody' do
             find("tr[data-id='#{overview.id}']   td.table-draggable").click
           end
-
-          within '.ticket_selector' do
-            # trigger the preview
-            fill_in 'condition::ticket.customer_id::value_completion',	with: customer_one.firstname
-          end
         end
 
         context 'when single customer exists' do
@@ -267,11 +262,6 @@
           within '.table-overview .js-tableBody' do
             find("tr[data-id='#{overview.id}']   td.table-draggable").click
           end
-
-          within '.ticket_selector' do
-            # trigger the preview
-            fill_in 'condition::ticket.owner_id::value_completion',	with: owner_one.firstname
-          end
         end
 
         context 'when single owner exists' do
@@ -348,11 +338,6 @@
           within '.table-overview .js-tableBody' do
             find("tr[data-id='#{overview.id}']   td.table-draggable").click
           end
-
-          within '.ticket_selector' do
-            # trigger the preview
-            fill_in 'condition::ticket.organization_id::value_completion',	with: organization_one.name
-          end
         end
 
         context 'when single organization exists' do