Skip to content

Commit

Permalink
Removed nullifying on dispose.
Browse files Browse the repository at this point in the history
Official comment from VM guy is that it isn't needed.
  • Loading branch information
mrdoob committed Dec 25, 2012
1 parent 6f001e6 commit b7278c5
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 29 deletions.
1 change: 0 additions & 1 deletion examples/webgl_test_memory.html
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@
geometry.dispose();
material.dispose();
texture.dispose();
mesh.dispose();

}

Expand Down
6 changes: 0 additions & 6 deletions src/core/Geometry.js
Original file line number Diff line number Diff line change
Expand Up @@ -740,12 +740,6 @@ THREE.Geometry.prototype = {

this.dispatchEvent( { type: 'dispose' } );

for ( var property in this ) {

this[ property ] = null;

}

}

};
Expand Down
10 changes: 0 additions & 10 deletions src/core/Object3D.js
Original file line number Diff line number Diff line change
Expand Up @@ -349,16 +349,6 @@ THREE.Object3D.prototype = {

return object;

},

dispose: function () {

for ( var property in this ) {

this[ property ] = null;

}

}

};
Expand Down
6 changes: 0 additions & 6 deletions src/materials/Material.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,6 @@ THREE.Material.prototype.dispose = function () {

this.dispatchEvent( { type: 'dispose' } );

for ( var property in this ) {

this[ property ] = null;

}

};

THREE.MaterialIdCount = 0;
6 changes: 0 additions & 6 deletions src/textures/Texture.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,6 @@ THREE.Texture.prototype = {

this.dispatchEvent( { type: 'dispose' } );

for ( var property in this ) {

this[ property ] = null;

}

}

};
Expand Down

0 comments on commit b7278c5

Please sign in to comment.