SKA-33689: Reading list error after drag and drop citation into h1 (s…

…akaiproject#5087)
mmg-3 · Dec 8, 2017 · 1a9c450 · 1a9c450
1 parent a10cfd6
commit 1a9c450
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/...ions/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseCitationService.java b/...ions/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseCitationService.java
@@ -3230,11 +3230,15 @@ protected void set(BasicCitationCollection other, boolean isTemporary)
 						BasicCitation newCitation = new BasicCitation();
 						newCitation.copy(oldCitation);
 						newCitation.m_temporary = isTemporary;
-						this.saveCitation(newCitation);
+						if (isTemporary) { // save the citation if it's not saved yet
+							this.saveCitation(newCitation);
+						}
 
 						// copy the citation's citationCollectionOrder
 						CitationCollectionOrder newCitationCollectionOrder = citationCollectionOrder.copy(this.getId(), newCitation.getId());
-						this.saveCitationCollectionOrder(newCitationCollectionOrder);
+						if (isTemporary){ // save the citationCollectionOrder if it's not saved yet
+							this.saveCitationCollectionOrder(newCitationCollectionOrder);
+						}
 
 					} catch (IdUnusedException e) {
 						M_log.warn("copying citationcollectionorder(" + citationCollectionOrder.getCitationid() + ") ==> " + citationCollectionOrder.getValue(), e);
@@ -3243,7 +3247,9 @@ protected void set(BasicCitationCollection other, boolean isTemporary)
 				else {
 					// copy the citationCollectionOrder
 					CitationCollectionOrder newCitationCollectionOrder = citationCollectionOrder.copy(this.getId());
-					this.saveCitationCollectionOrder(newCitationCollectionOrder);
+					if (isTemporary){ // save the citationCollectionOrder if it's not saved yet
+						this.saveCitationCollectionOrder(newCitationCollectionOrder);
+					}
 				}
 			}