Skip to content

Commit

Permalink
[internal] add TODOs for issue 13879 re compiling wrapper binaries (p…
Browse files Browse the repository at this point in the history
…antsbuild#13883)

Add TODOs related to consolidating compilation of wrapper binaries in common rules as per pantsbuild#13879.

[ci skip-rust]

[ci skip-build-wheels]
  • Loading branch information
Tom Dyas authored Dec 14, 2021
1 parent e010b93 commit 6f85d25
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/python/pants/backend/codegen/protobuf/scala/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ async def materialize_jvm_plugins(request: MaterializeJvmPluginsRequest) -> Mate
SHIM_SCALA_VERSION = "2.13.7"


# TODO(13879): Consolidate compilation of wrapper binaries to common rules.
@rule
async def setup_scalapb_shim_classfiles(
scalapb: ScalaPBSubsystem, jdk_setup: JdkSetup, bash: BashBinary
Expand Down
1 change: 1 addition & 0 deletions src/python/pants/backend/go/go_sources/load_go_binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def get_file(file_name: str) -> bytes:
return tuple(FileContent(f, get_file(f)) for f in file_names)


# TODO(13879): Maybe see if can consolidate compilation of wrapper binaries to common rules with Scala/Java?
@rule
async def setup_go_binary(request: LoadedGoBinaryRequest) -> LoadedGoBinary:
file_contents = setup_files(request.dir_name, request.file_names)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class JavaParserCompiledClassfiles:
digest: Digest


# TODO(13879): Consolidate compilation of wrapper binaries to common rules.
@rule
async def build_processors(bash: BashBinary, jdk_setup: JdkSetup) -> JavaParserCompiledClassfiles:
dest_dir = "classfiles"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ async def resolve_fallible_result_to_analysis(
)


# TODO(13879): Consolidate compilation of wrapper binaries to common rules.
@rule
async def setup_scala_parser_classfiles(
bash: BashBinary, jdk_setup: JdkSetup
Expand Down

0 comments on commit 6f85d25

Please sign in to comment.