Skip to content

Commit

Permalink
ocfs2: Change some lock status member in ocfs2_lock_res to char.
Browse files Browse the repository at this point in the history
Commit 83fd9c7 changes l_level, l_requested and l_blocking of
ocfs2_lock_res from int to unsigned char. But actually it is
initially as -1(ocfs2_lock_res_init_common) which
correspoding to 255 for unsigned char. So the whole dlm lock
mechanism doesn't work now which means a disaster to ocfs2.

Cc: Goldwyn Rodrigues <[email protected]>
Signed-off-by: Tao Ma <[email protected]>
Signed-off-by: Joel Becker <[email protected]>
  • Loading branch information
Tao Ma authored and Joel Becker committed Nov 13, 2010
1 parent 2d3b07c commit 1c66b36
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/ocfs2/ocfs2.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ struct ocfs2_lock_res {
char l_name[OCFS2_LOCK_ID_MAX_LEN];
unsigned int l_ro_holders;
unsigned int l_ex_holders;
unsigned char l_level;
char l_level;
char l_requested;
char l_blocking;

/* Data packed - type enum ocfs2_lock_type */
unsigned char l_type;
Expand All @@ -169,8 +171,6 @@ struct ocfs2_lock_res {
unsigned char l_action;
/* Data packed - enum type ocfs2_unlock_action */
unsigned char l_unlock_action;
unsigned char l_requested;
unsigned char l_blocking;
unsigned int l_pending_gen;

spinlock_t l_lock;
Expand Down

0 comments on commit 1c66b36

Please sign in to comment.