Skip to content

Commit

Permalink
edac: add edac_device_alloc_index()
Browse files Browse the repository at this point in the history
Add edac_device_alloc_index(), because for MAPLE platform there may
exist several EDAC driver modules that could make use of
edac_device_ctl_info structure at the same time. The index allocation
for these structures should be taken care of by EDAC core.

[[email protected]: cleanups]
Signed-off-by: Harry Ciao <[email protected]>
Cc: Doug Thompson <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Kumar Gala <[email protected]>
Cc: Paul Mackerras <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
qcao-zz authored and torvalds committed Jun 18, 2009
1 parent 2a9036a commit 1dc9b70
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/edac/amd8111_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#define AMD8111_EDAC_MOD_STR "amd8111_edac"

#define PCI_DEVICE_ID_AMD_8111_PCI 0x7460
static int edac_dev_idx;

enum amd8111_edac_devs {
LPC_BRIDGE = 0,
Expand Down Expand Up @@ -377,7 +376,7 @@ static int amd8111_dev_probe(struct pci_dev *dev,
* edac_device_ctl_info, but make use of existing
* one instead.
*/
dev_info->edac_idx = edac_dev_idx++;
dev_info->edac_idx = edac_device_alloc_index();
dev_info->edac_dev =
edac_device_alloc_ctl_info(0, dev_info->ctl_name, 1,
NULL, 0, 0,
Expand Down
1 change: 1 addition & 0 deletions drivers/edac/edac_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,7 @@ extern void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
int inst_nr, int block_nr, const char *msg);
extern void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
int inst_nr, int block_nr, const char *msg);
extern int edac_device_alloc_index(void);

/*
* edac_pci APIs
Expand Down
14 changes: 14 additions & 0 deletions drivers/edac/edac_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,20 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev,
mutex_unlock(&device_ctls_mutex);
}

/*
* edac_device_alloc_index: Allocate a unique device index number
*
* Return:
* allocated index number
*/
int edac_device_alloc_index(void)
{
static atomic_t device_indexes = ATOMIC_INIT(0);

return atomic_inc_return(&device_indexes) - 1;
}
EXPORT_SYMBOL_GPL(edac_device_alloc_index);

/**
* edac_device_add_device: Insert the 'edac_dev' structure into the
* edac_device global list and create sysfs entries associated with
Expand Down

0 comments on commit 1dc9b70

Please sign in to comment.