Skip to content

Commit

Permalink
powerpc: add Altivec/VMX state to coredumps
Browse files Browse the repository at this point in the history
Update dump_task_altivec() (which has so far never been put to use) so that
it dumps the Altivec/VMX registers (VR[0] - VR[31], VSCR and VRSAVE) in the
same format as the ptrace get_vrregs(), and add the appropriate glue
typedef and #defines to make it work.

A new note type of NT_PPC_VMX was chosen to be 0x100 (arbitrarily) because
it allows the low range values to be used for more generic purposes and
0x100 seems an adequate starting point for PowerPC extensions.

Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Mark Nelson authored and Linus Torvalds committed Oct 17, 2007
1 parent 5b20cd8 commit 1f7d666
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 3 deletions.
28 changes: 25 additions & 3 deletions arch/powerpc/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,32 @@ void flush_altivec_to_thread(struct task_struct *tsk)
}
}

int dump_task_altivec(struct pt_regs *regs, elf_vrregset_t *vrregs)
int dump_task_altivec(struct task_struct *tsk, elf_vrregset_t *vrregs)
{
flush_altivec_to_thread(current);
memcpy(vrregs, &current->thread.vr[0], sizeof(*vrregs));
/* ELF_NVRREG includes the VSCR and VRSAVE which we need to save
* separately, see below */
const int nregs = ELF_NVRREG - 2;
elf_vrreg_t *reg;
u32 *dest;

if (tsk == current)
flush_altivec_to_thread(tsk);

reg = (elf_vrreg_t *)vrregs;

/* copy the 32 vr registers */
memcpy(reg, &tsk->thread.vr[0], nregs * sizeof(*reg));
reg += nregs;

/* copy the vscr */
memcpy(reg, &tsk->thread.vscr, sizeof(*reg));
reg++;

/* vrsave is stored in the high 32bit slot of the final 128bits */
memset(reg, 0, sizeof(*reg));
dest = (u32 *)reg;
*dest = tsk->thread.vrsave;

return 1;
}
#endif /* CONFIG_ALTIVEC */
Expand Down
8 changes: 8 additions & 0 deletions include/asm-powerpc/elf.h
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,14 @@ static inline int dump_task_regs(struct task_struct *tsk,
extern int dump_task_fpu(struct task_struct *, elf_fpregset_t *);
#define ELF_CORE_COPY_FPREGS(tsk, elf_fpregs) dump_task_fpu(tsk, elf_fpregs)

typedef elf_vrregset_t elf_fpxregset_t;

#ifdef CONFIG_ALTIVEC
extern int dump_task_altivec(struct task_struct *, elf_vrregset_t *vrregs);
#define ELF_CORE_COPY_XFPREGS(tsk, regs) dump_task_altivec(tsk, regs)
#define ELF_CORE_XFPREG_TYPE NT_PPC_VMX
#endif

#endif /* __KERNEL__ */

/* ELF_HWCAP yields a mask that user programs can use to figure out what
Expand Down
1 change: 1 addition & 0 deletions include/linux/elf.h
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ typedef struct elf64_shdr {
#define NT_TASKSTRUCT 4
#define NT_AUXV 6
#define NT_PRXFPREG 0x46e62b7f /* copied from gdb5.1/include/elf/common.h */
#define NT_PPC_VMX 0x100 /* PowerPC Altivec/VMX registers */


/* Note header in a PT_NOTE section */
Expand Down

0 comments on commit 1f7d666

Please sign in to comment.