KVM: fix lock imbalance

There is a missing unlock on one fail path in ioapic_mmio_write, fix that. Signed-off-by: Jiri Slaby <[email protected]> Signed-off-by: Avi Kivity <[email protected]>
mna · Sep 10, 2009 · 27c4ba6 · 27c4ba6
1 parent 22fc029
commit 27c4ba6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
@@ -292,7 +292,7 @@ static int ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 		data = *(u32 *) val;
 	else {
 		printk(KERN_WARNING "ioapic: Unsupported size %d\n", len);
-		return 0;
+		goto unlock;
 	}
 
 	addr &= 0xff;
@@ -313,6 +313,7 @@ static int ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 	default:
 		break;
 	}
+unlock:
 	mutex_unlock(&ioapic->kvm->irq_lock);
 	return 0;
 }