Skip to content

Commit

Permalink
mm: make setup_zone_migrate_reserve() aware of overlapping nodes
Browse files Browse the repository at this point in the history
I have gotten to the root cause of the hugetlb badness I reported back on
August 15th.  My system has the following memory topology (note the
overlapping node):

            Node 0 Memory: 0x8000000-0x44000000
            Node 1 Memory: 0x0-0x8000000 0x44000000-0x80000000

setup_zone_migrate_reserve() scans the address range 0x0-0x8000000 looking
for a pageblock to move onto the MIGRATE_RESERVE list.  Finding no
candidates, it happily continues the scan into 0x8000000-0x44000000.  When
a pageblock is found, the pages are moved to the MIGRATE_RESERVE list on
the wrong zone.  Oops.

setup_zone_migrate_reserve() should skip pageblocks in overlapping nodes.

Signed-off-by: Adam Litke <[email protected]>
Acked-by: Mel Gorman <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Nishanth Aravamudan <[email protected]>
Cc: Andy Whitcroft <[email protected]>
Cc: <[email protected]>		[2.6.25.x, 2.6.26.x]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Adam Litke authored and torvalds committed Sep 3, 2008
1 parent 169ccbd commit 344c790
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,9 @@ static int move_freepages(struct zone *zone,
#endif

for (page = start_page; page <= end_page;) {
/* Make sure we are not inadvertently changing nodes */
VM_BUG_ON(page_to_nid(page) != zone_to_nid(zone));

if (!pfn_valid_within(page_to_pfn(page))) {
page++;
continue;
Expand Down Expand Up @@ -2516,6 +2519,10 @@ static void setup_zone_migrate_reserve(struct zone *zone)
continue;
page = pfn_to_page(pfn);

/* Watch out for overlapping nodes */
if (page_to_nid(page) != zone_to_nid(zone))
continue;

/* Blocks with reserved pages will never free, skip them. */
if (PageReserved(page))
continue;
Expand Down

0 comments on commit 344c790

Please sign in to comment.