Skip to content

Commit

Permalink
spi: irq: Remove IRQF_DISABLED
Browse files Browse the repository at this point in the history
Since commit [e58aa3d: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <[email protected]>
Signed-off-by: Grant Likely <[email protected]>
  • Loading branch information
yongzhang0 authored and glikely committed Oct 24, 2011
1 parent 1458d16 commit 38ada21
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion drivers/spi/spi-bfin5xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ static int bfin_spi_setup(struct spi_device *spi)

if (chip->pio_interrupt && !drv_data->irq_requested) {
ret = request_irq(drv_data->spi_irq, bfin_spi_pio_irq_handler,
IRQF_DISABLED, "BFIN_SPI", drv_data);
0, "BFIN_SPI", drv_data);
if (ret) {
dev_err(&spi->dev, "Unable to register spi IRQ\n");
goto error;
Expand Down
2 changes: 1 addition & 1 deletion drivers/spi/spi-coldfire-qspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ static int __devinit mcfqspi_probe(struct platform_device *pdev)
goto fail2;
}

status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, IRQF_DISABLED,
status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, 0,
pdev->name, mcfqspi);
if (status) {
dev_dbg(&pdev->dev, "request_irq failed\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/spi/spi-ppc4xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ static int __init spi_ppc4xx_of_probe(struct platform_device *op)
/* Request IRQ */
hw->irqnum = irq_of_parse_and_map(np, 0);
ret = request_irq(hw->irqnum, spi_ppc4xx_int,
IRQF_DISABLED, "spi_ppc4xx_of", (void *)hw);
0, "spi_ppc4xx_of", (void *)hw);
if (ret) {
dev_err(dev, "unable to allocate interrupt\n");
goto free_gpios;
Expand Down
2 changes: 1 addition & 1 deletion drivers/spi/spi-sh-msiof.c
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
goto err2;
}

ret = request_irq(i, sh_msiof_spi_irq, IRQF_DISABLED,
ret = request_irq(i, sh_msiof_spi_irq, 0,
dev_name(&pdev->dev), p);
if (ret) {
dev_err(&pdev->dev, "unable to request irq\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/spi/spi-sh.c
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ static int __devinit spi_sh_probe(struct platform_device *pdev)
goto error2;
}

ret = request_irq(irq, spi_sh_irq, IRQF_DISABLED, "spi_sh", ss);
ret = request_irq(irq, spi_sh_irq, 0, "spi_sh", ss);
if (ret < 0) {
dev_err(&pdev->dev, "request_irq error\n");
goto error3;
Expand Down

0 comments on commit 38ada21

Please sign in to comment.