Skip to content

Commit

Permalink
[PATCH] BLOCK: Revert patch to hack around undeclared sigset_t in lin…
Browse files Browse the repository at this point in the history
…ux/compat.h

Revert Andrew Morton's patch to temporarily hack around the lack of a
declaration of sigset_t in linux/compat.h to make the block-disablement
patches build on IA64.  This got accidentally pushed to Linus and should
be fixed in a different manner.

Also make linux/compat.h #include asm/signal.h to gain a definition of
sigset_t so that it can externally declare sigset_from_compat().

This has been compile-tested for i386, x86_64, ia64, mips, mips64, frv, ppc and
ppc64 and run-tested on frv.

Signed-off-by: David Howells <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
dhowells authored and Linus Torvalds committed Oct 2, 2006
1 parent 9ec5209 commit 3f2e05e
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions arch/mips/kernel/signal_n32.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@

#include "signal-common.h"

extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);

/*
* Including <asm/unistd.h> would give use the 64-bit syscall numbers ...
*/
Expand Down Expand Up @@ -83,6 +81,8 @@ struct rt_sigframe_n32 {
#endif
};

extern void sigset_from_compat (sigset_t *set, compat_sigset_t *compat);

save_static_function(sysn32_rt_sigsuspend);
__attribute_used__ noinline static int
_sysn32_rt_sigsuspend(nabi_no_regargs struct pt_regs regs)
Expand Down
2 changes: 0 additions & 2 deletions fs/compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@

int compat_log = 1;

extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);

int compat_printk(const char *fmt, ...)
{
va_list ap;
Expand Down
1 change: 1 addition & 0 deletions include/linux/compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include <asm/compat.h>
#include <asm/siginfo.h>
#include <asm/signal.h>

#define compat_jiffies_to_clock_t(x) \
(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
Expand Down
2 changes: 0 additions & 2 deletions kernel/compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@

#include <asm/uaccess.h>

extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);

int get_compat_timespec(struct timespec *ts, const struct compat_timespec __user *cts)
{
return (!access_ok(VERIFY_READ, cts, sizeof(*cts)) ||
Expand Down

0 comments on commit 3f2e05e

Please sign in to comment.