block: no need to initialize rq->cmd in prepare_flush_fn hook

The block layer initializes rq->cmd (queue_flush calls rq_init) so prepare_flush_fn hooks don't need to do that. The purpose of this patch is to remove sizeof(rq->cmd), as a preparation for large command support, which changes rq->cmd from the static array to a pointer. sizeof(rq->cmd) will not make sense. Signed-off-by: FUJITA Tomonori <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Cc: James Bottomley <[email protected]> Cc: Jens Axboe <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
mna · Apr 29, 2008 · 4917fa2 · 4917fa2
1 parent 6f6a036
commit 4917fa2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
@@ -405,7 +405,6 @@ static void ps3disk_prepare_flush(struct request_queue *q, struct request *req)
 
 	dev_dbg(&dev->sbd.core, "%s:%u\n", __func__, __LINE__);
 
-	memset(req->cmd, 0, sizeof(req->cmd));
 	req->cmd_type = REQ_TYPE_FLUSH;
 }
 

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
@@ -860,7 +860,6 @@ static int sd_sync_cache(struct scsi_disk *sdkp)
 
 static void sd_prepare_flush(struct request_queue *q, struct request *rq)
 {
-	memset(rq->cmd, 0, sizeof(rq->cmd));
 	rq->cmd_type = REQ_TYPE_BLOCK_PC;
 	rq->timeout = SD_TIMEOUT;
 	rq->cmd[0] = SYNCHRONIZE_CACHE;
-Original file line number
+Diff line change
@@ Expand Up @@
     	dev_dbg(&dev->sbd.core, "%s:%u\n", __func__, __LINE__);
-    	memset(req->cmd, 0, sizeof(req->cmd));
     	req->cmd_type = REQ_TYPE_FLUSH;
     }
@@ Expand Down @@