Skip to content

Commit

Permalink
tulip: Fix dead 21041 ethernet after ifconfig down
Browse files Browse the repository at this point in the history
The de2104x did a pci_disable_device() in it's close function, but
the open function never does a pci_enable_device() and assumes that
the device is already enabled. Considering that downing the interface
is just a temporary thing the pci_disable_device() isn't a pretty good
idea and removing it from the close function just fixes the bug.

Signed-off-by: Thomas Bogendoerfer <[email protected]>
Acked-by: Grant Grundler <[email protected]>
Signed-off-by: Jeff Garzik <[email protected]>
  • Loading branch information
tsbogend authored and Jeff Garzik committed Sep 24, 2008
1 parent d877984 commit 7c0965e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/tulip/de2104x.c
Original file line number Diff line number Diff line change
@@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)

de_free_rings(de);
de_adapter_sleep(de);
pci_disable_device(de->pdev);
return 0;
}

0 comments on commit 7c0965e

Please sign in to comment.