Skip to content

Commit

Permalink
fs/exec.c: make do_coredump() void
Browse files Browse the repository at this point in the history
No one cares do_coredump()'s return value, and also it seems that it
is also not necessary. So make it void.

[[email protected]: coding-style fixes]
Signed-off-by: WANG Cong <[email protected]>
Cc: Alexander Viro <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
WANG Cong authored and torvalds committed Jan 6, 2009
1 parent 4cb0e11 commit 8cd3ac3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions fs/exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,7 @@ int get_dumpable(struct mm_struct *mm)
return (ret >= 2) ? 2 : ret;
}

int do_coredump(long signr, int exit_code, struct pt_regs * regs)
void do_coredump(long signr, int exit_code, struct pt_regs *regs)
{
struct core_state core_state;
char corename[CORENAME_MAX_SIZE + 1];
Expand Down Expand Up @@ -1842,5 +1842,5 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
put_cred(cred);
coredump_finish(mm);
fail:
return retval;
return;
}
2 changes: 1 addition & 1 deletion include/linux/binfmts.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ extern int setup_arg_pages(struct linux_binprm * bprm,
extern int bprm_mm_init(struct linux_binprm *bprm);
extern int copy_strings_kernel(int argc,char ** argv,struct linux_binprm *bprm);
extern void install_exec_creds(struct linux_binprm *bprm);
extern int do_coredump(long signr, int exit_code, struct pt_regs * regs);
extern void do_coredump(long signr, int exit_code, struct pt_regs *regs);
extern int set_binfmt(struct linux_binfmt *new);
extern void free_bprm(struct linux_binprm *);

Expand Down

0 comments on commit 8cd3ac3

Please sign in to comment.