Skip to content

Commit

Permalink
irda: Fix error propagation in ircomm_lmp_connect_response()
Browse files Browse the repository at this point in the history
The variable 'ret' is set but unused, and this pointed out that
errors from irlmp_connect_response() are not propagated to the
caller.

Note that this is currently academic since irlmp_connect_response()
always returns 0. :-)

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed May 19, 2011
1 parent ad63764 commit 8ce6eb1
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions net/irda/ircomm/ircomm_lmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self,
struct sk_buff *userdata)
{
struct sk_buff *tx_skb;
int ret;

IRDA_DEBUG(0, "%s()\n", __func__ );

Expand All @@ -100,9 +99,7 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self,
tx_skb = userdata;
}

ret = irlmp_connect_response(self->lsap, tx_skb);

return 0;
return irlmp_connect_response(self->lsap, tx_skb);
}

static int ircomm_lmp_disconnect_request(struct ircomm_cb *self,
Expand Down

0 comments on commit 8ce6eb1

Please sign in to comment.