Skip to content

Commit

Permalink
x86: make restore_fpu() use alternative assembler instructions
Browse files Browse the repository at this point in the history
It's really just a single instruction, conditional on whether the CPU
supports FXSR or not, so implement it as such instead of making it a
function that queries FXSR dynamically.

This means that the instruction just gets automatically rewritten to the
correct one at boot-time.
  • Loading branch information
Linus Torvalds committed Jul 22, 2005
1 parent b339a18 commit 8ed1383
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
11 changes: 0 additions & 11 deletions arch/i386/kernel/i387.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,6 @@ void kernel_fpu_begin(void)
}
EXPORT_SYMBOL_GPL(kernel_fpu_begin);

void restore_fpu( struct task_struct *tsk )
{
if ( cpu_has_fxsr ) {
asm volatile( "fxrstor %0"
: : "m" (tsk->thread.i387.fxsave) );
} else {
asm volatile( "frstor %0"
: : "m" (tsk->thread.i387.fsave) );
}
}

/*
* FPU tag word conversions.
*/
Expand Down
13 changes: 12 additions & 1 deletion include/asm-i386/i387.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,21 @@

extern void mxcsr_feature_mask_init(void);
extern void init_fpu(struct task_struct *);

/*
* FPU lazy state save handling...
*/
extern void restore_fpu( struct task_struct *tsk );

/*
* The "nop" is needed to make the instructions the same
* length.
*/
#define restore_fpu(tsk) \
alternative_input( \
"nop ; frstor %1", \
"fxrstor %1", \
X86_FEATURE_FXSR, \
"m" ((tsk)->thread.i387.fsave))

extern void kernel_fpu_begin(void);
#define kernel_fpu_end() do { stts(); preempt_enable(); } while(0)
Expand Down

0 comments on commit 8ed1383

Please sign in to comment.