Skip to content

Commit

Permalink
[PATCH] i386: system.h: remove extra semicolons and fix order
Browse files Browse the repository at this point in the history
include/asm-i386/system.h has trailing semicolons in some of the
macros that cause legitimate code to fail compilation, so remove
them. Also remove extra blank lines within one group of macros.

And put stts() and clts() back together; they got separated somehow.

Signed-off-by: Chuck Ebbert <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Chuck Ebbert authored and Linus Torvalds committed Jul 13, 2006
1 parent e47f317 commit b43c7ce
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions include/asm-i386/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
#define savesegment(seg, value) \
asm volatile("mov %%" #seg ",%0":"=rm" (value))

/*
* Clear and set 'TS' bit respectively
*/
#define clts() __asm__ __volatile__ ("clts")
#define read_cr0() ({ \
unsigned int __dummy; \
__asm__ __volatile__( \
Expand All @@ -94,7 +90,7 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
__dummy; \
})
#define write_cr0(x) \
__asm__ __volatile__("movl %0,%%cr0": :"r" (x));
__asm__ __volatile__("movl %0,%%cr0": :"r" (x))

#define read_cr2() ({ \
unsigned int __dummy; \
Expand All @@ -104,7 +100,7 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
__dummy; \
})
#define write_cr2(x) \
__asm__ __volatile__("movl %0,%%cr2": :"r" (x));
__asm__ __volatile__("movl %0,%%cr2": :"r" (x))

#define read_cr3() ({ \
unsigned int __dummy; \
Expand All @@ -114,7 +110,7 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
__dummy; \
})
#define write_cr3(x) \
__asm__ __volatile__("movl %0,%%cr3": :"r" (x));
__asm__ __volatile__("movl %0,%%cr3": :"r" (x))

#define read_cr4() ({ \
unsigned int __dummy; \
Expand All @@ -123,7 +119,6 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
:"=r" (__dummy)); \
__dummy; \
})

#define read_cr4_safe() ({ \
unsigned int __dummy; \
/* This could fault if %cr4 does not exist */ \
Expand All @@ -135,15 +130,19 @@ __asm__ __volatile__ ("movw %%dx,%1\n\t" \
: "=r" (__dummy): "0" (0)); \
__dummy; \
})

#define write_cr4(x) \
__asm__ __volatile__("movl %0,%%cr4": :"r" (x));
__asm__ __volatile__("movl %0,%%cr4": :"r" (x))

/*
* Clear and set 'TS' bit respectively
*/
#define clts() __asm__ __volatile__ ("clts")
#define stts() write_cr0(8 | read_cr0())

#endif /* __KERNEL__ */

#define wbinvd() \
__asm__ __volatile__ ("wbinvd": : :"memory");
__asm__ __volatile__ ("wbinvd": : :"memory")

static inline unsigned long get_limit(unsigned long segment)
{
Expand Down

0 comments on commit b43c7ce

Please sign in to comment.