Skip to content

Commit

Permalink
Only specify --no-link-platform when not specifying --aot, roll dart-…
Browse files Browse the repository at this point in the history
…lang sdk (flutter#13742)

* Only specify --no-link-platform when --aot isn't specified

* [dart_roll] Update to e68ca9b
  • Loading branch information
George Wright authored and iskakaushik committed Nov 8, 2019
1 parent 6ad57b0 commit 14db93a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ vars = {
# Dart is: https://github.com/dart-lang/sdk/blob/master/DEPS.
# You can use //tools/dart/create_updated_flutter_deps.py to produce
# updated revision list of existing dependencies.
'dart_revision': '4b9638aaa17203b4e4f9ceb8492faf6a11301999',
'dart_revision': 'e68ca9b652acdb642668a6acb5f630d5be6c03da',

# WARNING: DO NOT EDIT MANUALLY
# The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py
Expand Down
2 changes: 1 addition & 1 deletion ci/licenses_golden/licenses_third_party
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Signature: cb6a78a49c674537ebcffa756ccdea6b
Signature: d45bc36638d83a8d56574a59410d78d8

UNUSED LICENSES:

Expand Down
4 changes: 3 additions & 1 deletion tools/fuchsia/dart_kernel.gni
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ template("dart_kernel") {
"--packages=" + rebase_path(dot_packages),
"--target=dart_runner",
"--platform=" + rebase_path(platform_dill),
"--no-link-platform",
"--output=" + rebase_path(output),
]

Expand All @@ -64,6 +63,9 @@ template("dart_kernel") {
"--aot",
"--tfa",
]
} else {
# --no-link-platform is only valid when --aot isn't specified
args += [ "--no-link-platform" ]
}

if (defined(invoker.product) && invoker.product) {
Expand Down

0 comments on commit 14db93a

Please sign in to comment.