Skip to content

Commit

Permalink
Refactor vuln scan into separate yaml (flutter#41528)
Browse files Browse the repository at this point in the history
This removes the vuln scanning action from the scorecards yaml and into its own file. The additional file already existed but was not updated.

Fixes:
b/246821537

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
  • Loading branch information
sealesj authored Apr 27, 2023
1 parent 381f714 commit 3d6d915
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 55 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/scorecards-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,6 @@ on:
permissions: read-all

jobs:
vuln-scan:
name: Vulnerability scanning
runs-on: ubuntu-20.04
if: ${{ github.repository == 'flutter/engine' }}
steps:
- name: "Checkout code"
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
with:
persist-credentials: false
- name: "setup python"
uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b
with:
python-version: '3.7.7' # install the python version needed
- name: "execute py script"
run: python ci/deps_parser.py

scorecards:
name: Scorecards analysis
runs-on: ubuntu-latest
Expand Down
48 changes: 9 additions & 39 deletions .github/workflows/third_party_scan.yml
Original file line number Diff line number Diff line change
@@ -1,56 +1,26 @@
name: Third party dependency scan
name: Third party deps scan
on:
# Only the default branch is supported.
branch_protection_rule:
push:
branches: [ main ]
schedule:
- cron: "0 8 * * *" # runs daily at 08:00


# Declare default permissions as read only.
permissions: read-all

jobs:
analysis:
name: Third party dependency scan
runs-on: ubuntu-latest
permissions:
# Needed to upload the results to code-scanning dashboard.
security-events: write
actions: read
contents: read

vuln-scan:
name: Vulnerability scanning
runs-on: ubuntu-20.04
if: ${{ github.repository == 'flutter/engine' }}
steps:
- name: "Checkout code"
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
with:
persist-credentials: false

- name: setup python
- name: "setup python"
uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b
with:
python-version: '3.7.7' # install the python version needed

- name: install dependency
run: pip install git+https://github.com/psf/requests.git@4d394574f5555a8ddcc38f707e0c9f57f55d9a3b

- name: execute py script
run: python ci/deps_parser.py

- name: parse deps_parser output.txt
run: python ci/scan_flattened_deps.py

# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
with:
name: SARIF file
path: osvReport.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@d186a2a36cc67bfa1b860e6170d37fb9634742c7
with:
sarif_file: osvReport.sarif
- name: "execute py script"
run: python ci/deps_parser.py

0 comments on commit 3d6d915

Please sign in to comment.