Skip to content

Commit

Permalink
Reduce logspam in DirectoryAssetBundle (flutter#4690)
Browse files Browse the repository at this point in the history
It's not an error to request an asset that doesn't exist. In fact, we
request kernel_blob.bin unconditionally at startup, which doesn't
typically exist.
  • Loading branch information
abarth authored Feb 19, 2018
1 parent 13cf22c commit d0160df
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions assets/directory_asset_bundle.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ bool DirectoryAssetBundle::GetAsBuffer(const std::string& asset_name,
return false;
#else
fxl::UniqueFD asset_file(openat(fd_.get(), asset_name.c_str(), O_RDONLY));
if (!asset_file.is_valid()) {
FXL_LOG(ERROR) << "Could not load asset " << asset_name;
if (!asset_file.is_valid())
return false;
}

constexpr size_t kBufferSize = 1 << 16;
size_t offset = 0;
Expand Down

0 comments on commit d0160df

Please sign in to comment.